You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "codeconsole (via GitHub)" <gi...@apache.org> on 2026/04/06 22:26:52 UTC

[PR] g:flashMessages tag [grails-core]

codeconsole opened a new pull request, #15560:
URL: https://github.com/apache/grails-core/pull/15560

   ### Flash Messages Tag (`g:flashMessages`)                                                                                     
                                                  
     Introduces a new `<g:flashMessages />` tag that renders `flash.message`, `flash.error`, and `flash.warning` as Bootstrap 
     5 dismissible alerts with appropriate styling (success, danger, and warning respectively).                                          
                                                                                                                                         
     The tag automatically prevents duplicate rendering -- if called in both a page and its layout, only the first invocation produces
     output. All flash content is HTML-encoded to prevent XSS.
   
     The default layout (`main.gsp`) and all scaffolding templates now use this tag. If your application has custom views that render    
     flash messages manually, you can replace the boilerplate:
                                                                                                                                         
     ```xml                                                          
     <%-- Before --%>
     <g:if test="${flash.message}">
         <div class="alert alert-primary" role="alert">${flash.message}</div>
     </g:if>                                                                                                                             
      
     <%-- After --%>                                                                                                                     
     <g:flashMessages />                                             
   
     The tag supports optional attributes for customizing CSS classes, icons, ARIA role, and dismissibility. See the flashMessages tag
     reference for full details.
     ```
   
   This tag has been introduced to all default layouts so that every page has automatic access to displaying flash.* messages.   Multiple `<g:flashMessages />`  are supported, but the first one rendered is prioritized.   Because of this, if a view (e.g.: scaffold view)  has a `<g:flashMessages />`, that flash.message location is prioritized over the layout location. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4196300931

   > I know we ship with bootstrap as an example, but end grails applications technically don't have to use it. Do we default style any of other tags this way?
   
   @jdaugherty if you look at all the locations where this tag is being used (scaffold and default layouts), it is replacing bootstrap code.
   ```html
                   <g:if test="\${flash.message}">
                       <div class="alert alert-primary" role="alert"><i class="bi-info-circle"></i> \${flash.message}</div>
                   </g:if>
   ```
   
   @jamesfredley all those tags actually reference proprietary grails classes that end users shouldn't be using.  My plan was eventually to swap those defaults out to bootstrap classes considering all those hardcoded grails classes are no longer used and the css has since been deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4195762078

   
   | Tag(s) | What they emit | CSS classes |
   |---------|---------------|-------------|
   | `g:textField`, `g:form`, `g:select`, `g:datePicker`, `g:link` | Plain HTML (`<input>`, `<form>`, `<a>`) | **None** unless user passes `class` attribute |
   | `g:paginate`, `g:sortableColumn` | Links/spans | Generic classes: `prevLink`, `nextLink`, `step`, `currentStep`, `sortable`, `sorted asc` |
   | `g:renderErrors`, `g:renderException` | Error markup | Generic classes: `error-details`, `stack` |
   | `f:field`, `f:table` (fields plugin) | Scaffolding fields | Generic classes: `fieldcontain`, `property-list`, `required`, `even`/`odd` |
   
   
   All of these are framework-agnostic class names - none reference Bootstrap (`alert`, `btn`, `form-control`), Tailwind, or any other CSS framework.
   
   
   The classes are overridable via attributes (`messageClass`, `messageIcon`, etc.), but the defaults themselves are Bootstrap 5-specific.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4207041139

   @codeconsole This is for 7.1 though.  I'd agree with you if we were on bootstrap exclusively.  Although, I debate if we should do that with css frameworks like tailwind.  For 7.1, I think we should move it to it's own tag lib or make it configurable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4230253877

   > Should we scope the config keys to `grails.views.gsp.*`?
   
   yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#discussion_r3052094627


##########
grails-gsp/plugin/src/main/groovy/org/grails/plugins/web/taglib/ApplicationTagLib.groovy:
##########
@@ -471,4 +471,68 @@ class ApplicationTagLib implements ApplicationContextAware, InitializingBean, Gr
         // encoding is handled in GroovyPage.invokeTag and GroovyPage.captureTagOutput
         body()
     }
+
+    /**
+     * Renders flash.message, flash.error, and flash.warning as Bootstrap alert divs.
+     * Automatically skips rendering if already called during this request, preventing
+     * duplicate display when used in both pages and layouts.
+     *
+     * @emptyTag
+     *
+     * @attr messageClass CSS class for flash.message alerts (default: 'alert alert-success alert-dismissible fade show')
+     * @attr messageIcon Icon class for flash.message alerts (default: 'bi bi-check-circle me-2')
+     * @attr errorClass CSS class for flash.error alerts (default: 'alert alert-danger alert-dismissible fade show')
+     * @attr errorIcon Icon class for flash.error alerts (default: 'bi bi-exclamation-triangle me-2')
+     * @attr warningClass CSS class for flash.warning alerts (default: 'alert alert-warning alert-dismissible fade show')
+     * @attr warningIcon Icon class for flash.warning alerts (default: 'bi bi-exclamation-circle me-2')
+     * @attr role ARIA role for alert divs (default: 'alert')
+     * @attr dismissible Whether to show a close button (default: true)
+     */
+    Closure flashMessages = { attrs ->

Review Comment:
   We discussed this in the weekly and we need to release 7.1 soon.  For a quick resolution here and to make it in 7.1, we should either make this configurable at the app level or move it to the scaffolding project with a custom tag lib. Otherwise, we can revisit this in 8.0. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4207094003

   <!-- Bito Reply -->
   The comment proposes two quick fixes for the hardcoded Bootstrap 5 styling in the new `flashMessages` tag to meet the 7.1 release: 1) Add app-level config for CSS classes and icons (e.g., via `application.yml`), or 2) Implement as a custom tag in the scaffolding project instead of core. This avoids delaying the release while allowing flexibility for non-Bootstrap apps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4195523069

   I know we ship with bootstrap as an example, but end grails applications technically don't have to use it.  Do we default style any of other tags this way? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4230291828

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 2be6391ab2a74287e1685bc88c659be3a2f97c13
   ▶️ Tests:  35907 executed
   ⚪️ Checks: 35/35 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole merged PR #15560:
URL: https://github.com/apache/grails-core/pull/15560


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4201807185

   > Another possibility is to push a custom tag lib with the Scaffolding plugin. I don't think we should be putting css framework specific classes in grails-gsp. I'm ok to do that in scaffolding since there's precedence there.
   
   @jdaugherty isn't there already css framework specific classes in virtually every other grails tag? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4201997059

   > @jdaugherty isn't there already css framework specific classes in virtually every other grails tag?
   > 
   > This really has nothing to do with scaffolding. It targets `flash.message`s
   
   Doing some analysis with AI thinks that bootstrap classes aren't hard coded today - only the basic grails classes: 
   
   # Grails TagLib CSS Classes Audit
   
   An inventory of all hardcoded CSS classes in shipped Grails tag libraries.
   
   ## UrlMappingTagLib — Pagination & Sorting
   
   **File:** `grails-gsp/plugin/src/main/groovy/org/grails/plugins/web/taglib/UrlMappingTagLib.groovy`
   
   ### `<g:paginate>`
   
   | CSS Class | Overridable? | Notes |
   |-----------|-------------|-------|
   | `prevLink` | No | Applied to the previous page link |
   | `nextLink` | No | Applied to the next page link |
   | `step` | No | Applied to each page number link |
   | `step gap` | No | Hardcoded `<span class="step gap">..</span>` for ellipsis gaps |
   | `currentStep` | Yes (`activeClass` attr) | Default class for the active/current page |
   
   ### `<g:sortableColumn>`
   
   | CSS Class | Overridable? | Notes |
   |-----------|-------------|-------|
   | `sortable` | No | Always added to the column |
   | `sorted` | No | Added when column is the active sort column |
   | `asc` / `desc` | No | Sort direction appended as a class alongside `sorted` |
   
   ## FormFieldsTagLib — Field Wrappers
   
   **File:** `grails-fields/grails-app/taglib/grails/plugin/formfields/FormFieldsTagLib.groovy`
   
   ### `<f:field>`
   
   | CSS Class | Overridable? | Notes |
   |-----------|-------------|-------|
   | `fieldcontain` | Yes (`class` attr) | Default wrapper div class |
   | `error` | Yes (`invalidClass` attr) | Added when the field has validation errors |
   | `required` | Yes (`requiredClass` attr) | Added when the field is required |
   | `required-indicator` | No | Hardcoded on `<span>` containing `*` |
   
   ## RenderTagLib — Error/Exception Display
   
   **File:** `grails-gsp/grails-web-gsp-taglib/src/main/groovy/org/grails/plugins/web/taglib/RenderTagLib.groovy`
   
   ### `<g:renderException>`
   
   | CSS Class | Overridable? | Notes |
   |-----------|-------------|-------|
   | `error-details` | Yes (`detailsClass` attr) | Default class on the `<dl>` element |
   | `stack` | Yes (`stackClass` attr) | Default class on the `<pre>` element for stack traces |
   
   ## Summary
   
   | TagLib | Tag | Total Classes | Overridable | Not Overridable |
   |--------|-----|---------------|-------------|-----------------|
   | UrlMappingTagLib | `paginate` | 5 | 1 | 4 |
   | UrlMappingTagLib | `sortableColumn` | 3 | 0 | 3 |
   | FormFieldsTagLib | `field` | 4 | 3 | 1 |
   | RenderTagLib | `renderException` | 2 | 2 | 0 |
   | **Total** | | **14** | **6** | **8** |
   
   ## Assessment
   
   - **No CSS framework dependency.** The hardcoded class names (`sortable`, `step`, `error`, etc.) are semantic/functional names. They do not correspond to Bootstrap, Tailwind, or any other CSS framework.
   - **8 of 14 classes are not overridable.** The `paginate` and `sortableColumn` tags in `UrlMappingTagLib` are the primary concern, with 7 non-overridable classes between them. Users must target these specific class names in their stylesheets.
   - **Most FormFieldsTagLib and RenderTagLib defaults can be replaced** via tag attributes.
   - **`CustomTagLib.groovy`** in `grails-test-examples/` contains Bootstrap-like patterns (`panel`, `alert`, `badge`, `progress-bar`) but is a test fixture, not part of the shipped framework.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4217036896

   @codeconsole I'd like to call a vote tomorrow afternoon.  Can you try to get this feedback done on this ticket & the other exception logging ticket so I can proceed? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "sbglasius (via GitHub)" <gi...@apache.org>.
sbglasius commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4200911551

   @codeconsole My suggestion is to make generic output, and follow the way the fields plugin works.
   
   Have a structure like: 
   ```
   grails-app
   - views
     - _flash
       - _message.gsp
       - _error.gsp
       - _warning.gsp
   ```
   And if they are not defined revert back to sensible `default` values like `fields` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4202353524

   > Doing some analysis with AI: it thinks that bootstrap classes aren't hard coded today - only the basic grails classes:
   
   @jdaugherty what is the difference between a bootstrap css class or a custom grails class that requires importing an additional css rule?  At the end of the day, it is just a css class.  If you don't have bootstrap, you could just write your own rule for it or write no rule in which the css classes would have no effect.
   
   I would much rather see well thought out bootstrap classes than css classes that don't even exist anymore in the codebase.. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#discussion_r3058366415


##########
grails-gsp/plugin/src/main/groovy/org/grails/plugins/web/taglib/ApplicationTagLib.groovy:
##########
@@ -471,4 +471,68 @@ class ApplicationTagLib implements ApplicationContextAware, InitializingBean, Gr
         // encoding is handled in GroovyPage.invokeTag and GroovyPage.captureTagOutput
         body()
     }
+
+    /**
+     * Renders flash.message, flash.error, and flash.warning as Bootstrap alert divs.
+     * Automatically skips rendering if already called during this request, preventing
+     * duplicate display when used in both pages and layouts.
+     *
+     * @emptyTag
+     *
+     * @attr messageClass CSS class for flash.message alerts (default: 'alert alert-success alert-dismissible fade show')
+     * @attr messageIcon Icon class for flash.message alerts (default: 'bi bi-check-circle me-2')
+     * @attr errorClass CSS class for flash.error alerts (default: 'alert alert-danger alert-dismissible fade show')
+     * @attr errorIcon Icon class for flash.error alerts (default: 'bi bi-exclamation-triangle me-2')
+     * @attr warningClass CSS class for flash.warning alerts (default: 'alert alert-warning alert-dismissible fade show')
+     * @attr warningIcon Icon class for flash.warning alerts (default: 'bi bi-exclamation-circle me-2')
+     * @attr role ARIA role for alert divs (default: 'alert')
+     * @attr dismissible Whether to show a close button (default: true)
+     */
+    Closure flashMessages = { attrs ->

Review Comment:
   I'm happy to merge this if we have app level config values for this stuff.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole commented on code in PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#discussion_r3054234635


##########
grails-gsp/plugin/src/main/groovy/org/grails/plugins/web/taglib/ApplicationTagLib.groovy:
##########
@@ -471,4 +471,68 @@ class ApplicationTagLib implements ApplicationContextAware, InitializingBean, Gr
         // encoding is handled in GroovyPage.invokeTag and GroovyPage.captureTagOutput
         body()
     }
+
+    /**
+     * Renders flash.message, flash.error, and flash.warning as Bootstrap alert divs.
+     * Automatically skips rendering if already called during this request, preventing
+     * duplicate display when used in both pages and layouts.
+     *
+     * @emptyTag
+     *
+     * @attr messageClass CSS class for flash.message alerts (default: 'alert alert-success alert-dismissible fade show')
+     * @attr messageIcon Icon class for flash.message alerts (default: 'bi bi-check-circle me-2')
+     * @attr errorClass CSS class for flash.error alerts (default: 'alert alert-danger alert-dismissible fade show')
+     * @attr errorIcon Icon class for flash.error alerts (default: 'bi bi-exclamation-triangle me-2')
+     * @attr warningClass CSS class for flash.warning alerts (default: 'alert alert-warning alert-dismissible fade show')
+     * @attr warningIcon Icon class for flash.warning alerts (default: 'bi bi-exclamation-circle me-2')
+     * @attr role ARIA role for alert divs (default: 'alert')
+     * @attr dismissible Whether to show a close button (default: true)
+     */
+    Closure flashMessages = { attrs ->

Review Comment:
   @jdaugherty I don't think it is really has anything to do with scaffolding, so I can introduce config values with bootstrap defaults.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4196673258

   Just thinking out loud: Could the CSS class defaults be set (and overridden) in configuration? Then we could default to the Bootstrap theme classes in `grails-gsp` configuration and it would be easy to override "globally" in the application without having to set the classes explicitly in source.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4200711175

   Another possibility is to push a custom tag lib with the Scaffolding plugin.  I don't think we should be putting css framework specific classes in grails-gsp.  I'm ok to do that in scaffolding since there's precedence there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4201801359

   > Just thinking out loud: Could the CSS class defaults be set (and overridden) in configuration? Then we could default to the Bootstrap theme classes in `grails-gsp` configuration and it would be easy to override "globally" in the application without having to set the classes explicitly in source.
   
   @matrei 
   We could, and I am not opposed to doing that,  but how many locations do you actually anticipate using this tag?  
   1 layout and a couple of layouts?  if so, you just override the classes in the tag `<g:flashMessages messageClass="alert alert-info"  />`
   
   Of course the other option is don't use the tag at all. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] g:flashMessages tag [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15560:
URL: https://github.com/apache/grails-core/pull/15560#issuecomment-4227583292

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 77b8dee9844af0be3513be903890909e7771551d
   ▶️ Tests:  42191 executed
   ⚪️ Checks: 35/35 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org