You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/02/04 21:09:12 UTC
[GitHub] [knox] moresandeep commented on a change in pull request #252:
KNOX-2207 - TokenStateService revocation should remove persisted token state
moresandeep commented on a change in pull request #252: KNOX-2207 - TokenStateService revocation should remove persisted token state
URL: https://github.com/apache/knox/pull/252#discussion_r374923901
##########
File path: gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateService.java
##########
@@ -104,14 +104,15 @@ public long getTokenExpiration(final String token) {
@Override
public void revokeToken(final String token) {
- // Record the revocation by setting the expiration to -1
- updateExpiration(token, -1L);
+ /* no reason to keep revoked tokens around */
+ removeRevokedExpiredToken(token);
log.revokedToken(getTokenDisplayText(token));
}
@Override
protected boolean isRevoked(final String token) {
Review comment:
Sure, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services