You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by cs...@apache.org on 2021/06/14 08:46:53 UTC

[maven] branch MNG-7173-resolver-guice-module created (now d2ef32f)

This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a change to branch MNG-7173-resolver-guice-module
in repository https://gitbox.apache.org/repos/asf/maven.git.


      at d2ef32f  [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken

This branch includes the following new commits:

     new d2ef32f  [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


[maven] 01/01: [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken

Posted by cs...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch MNG-7173-resolver-guice-module
in repository https://gitbox.apache.org/repos/asf/maven.git

commit d2ef32f0bef85e4d6e2c163e440277b3080c06f4
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Mon Jun 14 10:45:06 2021 +0200

    [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken
    
    It is broken since 3.6.2 or so, when ModelBuilder got decorated with
    JSR330 injections, that work in sisu but not in Guice as it needs
    explicit bindings added.
    
    This is an UT that proves that module is incomplete.
---
 .../internal/MavenResolverModuleTest.java          | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/maven-resolver-provider/src/test/java/org/apache/maven/repository/internal/MavenResolverModuleTest.java b/maven-resolver-provider/src/test/java/org/apache/maven/repository/internal/MavenResolverModuleTest.java
new file mode 100644
index 0000000..6b0e1d7
--- /dev/null
+++ b/maven-resolver-provider/src/test/java/org/apache/maven/repository/internal/MavenResolverModuleTest.java
@@ -0,0 +1,33 @@
+package org.apache.maven.repository.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.google.inject.Guice;
+import org.eclipse.aether.RepositorySystem;
+import org.junit.jupiter.api.Test;
+
+public class MavenResolverModuleTest
+{
+    @Test
+    public void smokeTest()
+    {
+        Guice.createInjector( new MavenResolverModule() ).getInstance( RepositorySystem.class );
+    }
+}