You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org> on 2017/06/21 17:12:13 UTC
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Dimitris Tsirogiannis has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7248
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
IMPALA-5549: Remove deprecated fields from CatalogService API
Remove from TCatalogUpdateResult the deprecated fields that are no longer
used and modify the catalog to always populate the
'updated_catalog_objects' and 'removed_catalog_object' fields with the
updated/removed catalog objects.
Testing: Run core tests.
Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
---
M be/src/service/impala-server.cc
M common/thrift/CatalogService.thrift
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
3 files changed, 28 insertions(+), 111 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/7248/1
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
Patch Set 1:
IIRC, this was introduced because the permanent UDF changes broke some clients (ex: BDR) relying on the old API that returned a single updated/removed object. Is it not a problem anymore? Just want to be sure that we don't break them again.
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7248/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
Line 2916: }
> May be add a Preconditions check on updatedPrivs.size() > 1 just so that it
Good point. Done
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
Patch Set 3: Code-Review+2
Rebased. Keep Alex's +2
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7248
to look at the new patch set (#2).
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
IMPALA-5549: Remove deprecated fields from CatalogService API
Remove from TCatalogUpdateResult the deprecated fields that are no longer
used and modify the catalog to always populate the
'updated_catalog_objects' and 'removed_catalog_object' fields with the
updated/removed catalog objects.
Testing: Run core tests.
Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
---
M be/src/service/impala-server.cc
M common/thrift/CatalogService.thrift
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
3 files changed, 22 insertions(+), 103 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/7248/2
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
IMPALA-5549: Remove deprecated fields from CatalogService API
Remove from TCatalogUpdateResult the deprecated fields that are no longer
used and modify the catalog to always populate the
'updated_catalog_objects' and 'removed_catalog_object' fields with the
updated/removed catalog objects.
Testing: Run core tests.
Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Reviewed-on: http://gerrit.cloudera.org:8080/7248
Reviewed-by: Dimitris Tsirogiannis <dt...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/service/impala-server.cc
M common/thrift/CatalogService.thrift
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
3 files changed, 22 insertions(+), 103 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Dimitris Tsirogiannis: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
Patch Set 1:
> IIRC, this was introduced because the permanent UDF changes broke
> some clients (ex: BDR) relying on the old API that returned a
> single updated/removed object. Is it not a problem anymore? Just
> want to be sure that we don't break them again.
Since 5.12, BDR stopped using our catalog API. Hence, there is no need to keep these deprecated logic anymore.
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/775/
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Ok, Thanks for clarifying.
http://gerrit.cloudera.org:8080/#/c/7248/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
Line 2916: }
May be add a Preconditions check on updatedPrivs.size() > 1 just so that it doesn't show up as an NPE in some edge case? (or) Probably surround the whole block with if (!updatedPrivs.isEmpty())
--
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: Yes