You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/07/31 18:42:40 UTC
[jira] [Commented] (AMQ-5301) Destination should not have numerical
suffix for single-dest perf tests
[ https://issues.apache.org/jira/browse/AMQ-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081091#comment-14081091 ]
ASF GitHub Bot commented on AMQ-5301:
-------------------------------------
GitHub user jkorab opened a pull request:
https://github.com/apache/activemq/pull/38
Fix for AMQ-5301
Modified the destination construction logic so that numerical prefixes are appended only if sysTest.totalDests is greater than 1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkorab/activemq trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 1702265c73296955a1c2baf72d405a805efe8cd9
Author: jkorab <ja...@gmail.com>
Date: 2014-07-31T16:15:03Z
Modified so that single-destination tests do not append a numerical prefix.
commit 42ac31d04ddddfc23bdc6718ae6d80e40dc4f772
Author: jkorab <ja...@gmail.com>
Date: 2014-07-31T16:37:34Z
Unified the logic for appending numerical prefixes between normal one-off destinations and composite destinations. Fixed composite destination construction logic that created 2 destinations when sysTest.totalDests was 1 or 2.
----
> Destination should not have numerical suffix for single-dest perf tests
> -----------------------------------------------------------------------
>
> Key: AMQ-5301
> URL: https://issues.apache.org/jira/browse/AMQ-5301
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Performance Test
> Affects Versions: 5.10.0
> Reporter: Jakub Korab
> Priority: Minor
>
> The performance test module assumes that multiple destinations will be put under load, and thereby assigns a numerical suffix to the destination name specified on the command line. Thus a producer/consumer configured to topic://foo will actually send/receive from topic://foo.0. This is annoying, as when load testing a particular broker setup (such as with composite destinations), you need to be explicit about which destination is being targeted and it is not always possible to tweak the broker configuration.
> I propose that for single-destination tests, no numerical suffix is added. Patch incoming.
--
This message was sent by Atlassian JIRA
(v6.2#6252)