You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/09 01:23:54 UTC
[GitHub] codecov-io commented on issue #3668: Split validation manager tasks
into separate periodic tasks
codecov-io commented on issue #3668: Split validation manager tasks into separate periodic tasks
URL: https://github.com/apache/incubator-pinot/pull/3668#issuecomment-452524270
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3668?src=pr&el=h1) Report
> Merging [#3668](https://codecov.io/gh/apache/incubator-pinot/pull/3668?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/46ad4f95996e77da8b516535daa8be4d89c09d36?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `41.72%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3668?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3668 +/- ##
============================================
+ Coverage 70.64% 70.67% +0.02%
Complexity 4 4
============================================
Files 1012 1014 +2
Lines 46459 46519 +60
Branches 6212 6214 +2
============================================
+ Hits 32823 32878 +55
- Misses 11472 11477 +5
Partials 2164 2164
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3668?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../core/realtime/PinotLLCRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVhbHRpbWUvUGlub3RMTENSZWFsdGltZVNlZ21lbnRNYW5hZ2VyLmphdmE=) | `71.57% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmV0ZW50aW9uL1JldGVudGlvbk1hbmFnZXIuamF2YQ==) | `72.72% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vT2ZmbGluZVNlZ21lbnRJbnRlcnZhbENoZWNrZXIuamF2YQ==) | `25.27% <25%> (ø)` | `0 <0> (?)` | |
| [...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vQnJva2VyUmVzb3VyY2VWYWxpZGF0aW9uTWFuYWdlci5qYXZh) | `26.31% <26.31%> (ø)` | `0 <0> (?)` | |
| [.../com/linkedin/pinot/controller/ControllerConf.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL0NvbnRyb2xsZXJDb25mLmphdmE=) | `41.95% <29.54%> (+0.12%)` | `0 <0> (ø)` | :arrow_down: |
| [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vUmVhbHRpbWVTZWdtZW50VmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `52.38% <52.38%> (ø)` | `0 <0> (?)` | |
| [...m/linkedin/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL0NvbnRyb2xsZXJTdGFydGVyLmphdmE=) | `61.95% <57.14%> (-0.76%)` | `0 <0> (ø)` | |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `81.81% <0%> (-5.46%)` | `0% <0%> (ø)` | |
| [...e/operator/dociditerators/BitmapDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL0JpdG1hcERvY0lkSXRlcmF0b3IuamF2YQ==) | `60.71% <0%> (-3.58%)` | `0% <0%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/incubator-pinot/pull/3668/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3668?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3668?src=pr&el=footer). Last update [46ad4f9...96255c9](https://codecov.io/gh/apache/incubator-pinot/pull/3668?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org