You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by rg...@apache.org on 2015/06/12 23:03:20 UTC
svn commit: r1685168 - in /zookeeper/branches/branch-3.5: CHANGES.txt
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
Author: rgs
Date: Fri Jun 12 21:03:20 2015
New Revision: 1685168
URL: http://svn.apache.org/r1685168
Log:
ZOOKEEPER-2214: Findbugs warning: LearnerHandler.packetToString Dead
store to local variable (Hongchao Deng via rgs)
Modified:
zookeeper/branches/branch-3.5/CHANGES.txt
zookeeper/branches/branch-3.5/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
Modified: zookeeper/branches/branch-3.5/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/branches/branch-3.5/CHANGES.txt?rev=1685168&r1=1685167&r2=1685168&view=diff
==============================================================================
--- zookeeper/branches/branch-3.5/CHANGES.txt (original)
+++ zookeeper/branches/branch-3.5/CHANGES.txt Fri Jun 12 21:03:20 2015
@@ -189,6 +189,9 @@ IMPROVEMENTS:
ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop
(Akihiro Suda via rgs)
+ ZOOKEEPER-2214: Findbugs warning: LearnerHandler.packetToString Dead
+ store to local variable (Hongchao Deng via rgs)
+
Release 3.5.0 - 8/4/2014
NEW FEATURES:
Modified: zookeeper/branches/branch-3.5/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
URL: http://svn.apache.org/viewvc/zookeeper/branches/branch-3.5/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java?rev=1685168&r1=1685167&r2=1685168&view=diff
==============================================================================
--- zookeeper/branches/branch-3.5/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java (original)
+++ zookeeper/branches/branch-3.5/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java Fri Jun 12 21:03:20 2015
@@ -255,9 +255,8 @@ public class LearnerHandler extends ZooK
}
static public String packetToString(QuorumPacket p) {
- String type = null;
+ String type;
String mess = null;
- Record txn = null;
switch (p.getType()) {
case Leader.ACK:
@@ -279,7 +278,7 @@ public class LearnerHandler extends ZooK
type = "PROPOSAL";
TxnHeader hdr = new TxnHeader();
try {
- txn = SerializeUtils.deserializeTxn(p.getData(), hdr);
+ SerializeUtils.deserializeTxn(p.getData(), hdr);
// mess = "transaction: " + txn.toString();
} catch (IOException e) {
LOG.warn("Unexpected exception",e);