You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/10 02:57:50 UTC

[GitHub] [incubator-nuttx] CheryDan commented on a change in pull request #4814: net/can/can_recvmsg.c : put can_readahead in critical section

CheryDan commented on a change in pull request #4814:
URL: https://github.com/apache/incubator-nuttx/pull/4814#discussion_r746211212



##########
File path: net/can/can_recvmsg.c
##########
@@ -622,7 +623,14 @@ ssize_t can_recvmsg(FAR struct socket *psock, FAR struct msghdr *msg,
    * socket has been disconnected.
    */
 
+  /* The following operations must be performed with interrupts
+   * disabled because iob_tryadd_queue() may be called from an interrupt

Review comment:
       iob_tryalloc_qentry is already in CAN interrupt ,but iob_remove_queue in can_recvmsg does not  hold critical section 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org