You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2018/07/16 00:47:00 UTC
[jira] [Commented] (LUCENE-8398)
TieredMergePolicy.getMaxMergedSegmentMB has rounding error
[ https://issues.apache.org/jira/browse/LUCENE-8398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544713#comment-16544713 ]
Erick Erickson commented on LUCENE-8398:
----------------------------------------
Same patch without inadvertent edit in CHANGES.txt.
> TieredMergePolicy.getMaxMergedSegmentMB has rounding error
> ----------------------------------------------------------
>
> Key: LUCENE-8398
> URL: https://issues.apache.org/jira/browse/LUCENE-8398
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: LUCENE-8398.patch, LUCENE-8398.patch
>
>
> This is largely a test artifact since it's unlikely to show up for realistically sized segments, but the fix is simple and safe.
> This code first does long division then promotes to double for the last calculation.
> {code}
> return maxMergedSegmentBytes/1024/1024.;
> {code}
> The error can be reproduced with: -Dtests.seed=EF80BCABAD74A7CF
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org