You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/30 21:30:02 UTC

[jira] [Commented] (TINKERPOP-1821) Consistent behavior of self-referencing edges

    [ https://issues.apache.org/jira/browse/TINKERPOP-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225768#comment-16225768 ] 

ASF GitHub Bot commented on TINKERPOP-1821:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/739

    TINKERPOP-1821: Consistent behavior of self-referencing edges

    https://issues.apache.org/jira/browse/TINKERPOP-1821
    
    Added test for self-edges and fixed a semantic issue in `Neo4jGraph` regarding self edges not being repeated on `BOTH`.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1821

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #739
    
----
commit 7f640f7e6d863cde1858d6bfa3ff502fd93a8663
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-10-30T15:06:02Z

    TINKERPOP-1821 Added tests for consistent traversal behavior around self-referencing edges

commit 5d68ca17160e4977eddfdb688f93d37440897957
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2017-10-30T21:28:37Z

    fixed up a self-edge test and Neo4jVertex to support repeat edges on BOTH.

----


> Consistent behavior of self-referencing edges
> ---------------------------------------------
>
>                 Key: TINKERPOP-1821
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1821
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.6
>            Reporter: stephen mallette
>            Assignee: Marko A. Rodriguez
>
> Given discussions here:
> https://lists.apache.org/thread.html/adcfa13130026896da215be257fd26b309820c1cd5b5d359ed9cdfa2@%3Cdev.tinkerpop.apache.org%3E
> we needed to include a test to ensure consistency of the traversal behavior around self-referencing edges in relation to
> {code}
> g.V().bothE()
> g.V().both()
> {code}
> The expected behavior is already present in TinkerGraph and that expected behavior is as follows:
> {code}
> gremlin> g.addV().as("a").addE("self").to("a").iterate()
> gremlin> g.V().bothE()
> ==>e[19][18-self->18]
> ==>e[19][18-self->18]
> gremlin> g.V().both()
> ==>v[18]
> ==>v[18]
> {code}
> This  may break a number of providers as we've not had a test for this behavior until now - we should provide some upgrade documentation to call attention to this issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)