You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/14 22:24:56 UTC
Review Request 64627: Fixed unit error and clang compile error for
SLRP and its tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64627/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.
Repository: mesos
Description
-------
Fixed unit error and clang compile error for SLRP and its tests.
Diffs
-----
src/resource_provider/storage/provider.cpp 17acf1b430b81e31bd97b117a44477eebab7e6f4
src/tests/storage_local_resource_provider_tests.cpp a3bea31f331a0cd2a4bea1ab0f75665157510830
Diff: https://reviews.apache.org/r/64627/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64627: Fixed unit error and clang compile error
for SLRP and its tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64627/#review193854
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 64627`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64627
Relevant logs:
- [apply-review-64627-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64627/logs/apply-review-64627-stdout.log):
```
error: patch failed: src/tests/storage_local_resource_provider_tests.cpp:601
error: src/tests/storage_local_resource_provider_tests.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Dec. 14, 2017, 10:24 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64627/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 10:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed unit error and clang compile error for SLRP and its tests.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 17acf1b430b81e31bd97b117a44477eebab7e6f4
> src/tests/storage_local_resource_provider_tests.cpp a3bea31f331a0cd2a4bea1ab0f75665157510830
>
>
> Diff: https://reviews.apache.org/r/64627/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64627: Fixed unit error in storage local resource
provider.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64627/#review193867
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 14, 2017, 11:31 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64627/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 11:31 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed unit error in storage local resource provider.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 17acf1b430b81e31bd97b117a44477eebab7e6f4
>
>
> Diff: https://reviews.apache.org/r/64627/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64627: Fixed unit error in storage local resource
provider.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64627/
-----------------------------------------------------------
(Updated Dec. 14, 2017, 11:31 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Fixed unit error in storage local resource provider.
Repository: mesos
Description (updated)
-------
Fixed unit error in storage local resource provider.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp 17acf1b430b81e31bd97b117a44477eebab7e6f4
Diff: https://reviews.apache.org/r/64627/diff/2/
Changes: https://reviews.apache.org/r/64627/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao