You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2017/11/30 18:51:20 UTC
svn commit: r1816743 - /tomcat/trunk/res/findbugs/filter-false-positives.xml
Author: markt
Date: Thu Nov 30 18:51:20 2017
New Revision: 1816743
URL: http://svn.apache.org/viewvc?rev=1816743&view=rev
Log:
Few more false positives
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1816743&r1=1816742&r2=1816743&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Thu Nov 30 18:51:20 2017
@@ -852,6 +852,16 @@
<Bug code="Dm" />
</Match>
<Match>
+ <!-- URLs used are always provided by the container so would normally be -->
+ <!-- file URLs. -->
+ <Class name="org.apache.tomcat.util.descriptor.tld.TldResourcePath" />
+ <Or>
+ <Method name="equals" />
+ <Method name="hashCode" />
+ </Or>
+ <Bug pattern="DMI_BLOCKING_METHODS_ON_URL" />
+ </Match>
+ <Match>
<!-- NPE is desired as it indicates an error condition -->
<Class name="org.apache.tomcat.util.digester.CallMethodRule"/>
<Method name="end"/>
@@ -900,6 +910,18 @@
<Bug code="SF" />
</Match>
<Match>
+ <!-- Reader instance always accepts -ve skip values and there is -->
+ <!-- always enough space to skip back the requested amount. -->
+ <Class name="org.apache.tomcat.util.http.parser.HttpParser" />
+ <Or>
+ <Method name="skipConstant" />
+ <Method name="readToken" />
+ <Method name="readQuotedToken" />
+ <Method name="readLhex" />
+ </Or>
+ <Bug pattern="SR_NOT_CHECKED" />
+ </Match>
+ <Match>
<!-- Hiding of field in superclass is deliberate -->
<Class name="org.apache.tomcat.util.modeler.NotificationInfo"/>
<Field name="info" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org