You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/05 23:48:03 UTC

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2229: da1469x/hal_flash: Fix write boundaries

apache-mynewt-bot commented on issue #2229: da1469x/hal_flash: Fix write boundaries
URL: https://github.com/apache/mynewt-core/pull/2229#issuecomment-595502539
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/mcu/dialog/da1469x/src/hal_flash.c
   <details>
   
   ```diff
   @@ -330,9 +330,9 @@
         * Due to the remap specified in the datasheet, 0->0x80000 (8 MBytes) are
         * remapped, hence that needs to be considered as well.
         */
   -    if ((((uint32_t)src < MCU_MEM_QSPIF_M_START_ADDRESS)       &&
   +    if ((((uint32_t)src < MCU_MEM_QSPIF_M_START_ADDRESS) &&
             ((uint32_t)src >= MCU_MEM_QSPIF_M_END_REMAP_ADDRESS)) ||
   -         ((uint32_t)src >= MCU_MEM_QSPIF_M_END_ADDRESS)) {
   +        ((uint32_t)src >= MCU_MEM_QSPIF_M_END_ADDRESS)) {
            return false;
        }
    
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services