[GitHub] [jena] kinow commented on a change in pull request #869: Release preparation

[GitBox <gi...@apache.org>]

kinow commented on a change in pull request #869:
URL: https://github.com/apache/jena/pull/869#discussion_r528403435



##########
File path: jena-fuseki2/jena-fuseki-webapp/src/main/java/org/apache/jena/fuseki/mgt/Backup.java
##########
@@ -61,18 +61,15 @@ public static String chooseFileName(String dsName) {
     // same dataset multiple times at the same time.
     private static Set<DatasetGraph> activeBackups = Collections.newSetFromMap(new ConcurrentHashMap<>());
 
-    /** Perform a backup.
-     *  A backup is a dump of the dataset in compressed N-Quads, done inside a transaction.
+    /**
+     * Perform a backup.
+     * <p>
+     * A backup is a dump of the dataset in compressed N-Quads, done inside a transaction.
      */
     public static void backup(Transactional transactional, DatasetGraph dsg, String backupfile) {
         if ( transactional == null )
             transactional = new TransactionalNull();
-        transactional.begin(ReadWrite.READ);
-        try {
-            Backup.backup(dsg, backupfile);
-        } finally {
-            transactional.end();
-        }
+        Txn.executeRead(transactional,()->backup(dsg, backupfile));

Review comment:
       missing space after comma (just in case it might be picked later by linter/IDE/etc?)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org