[GitHub] [hadoop] lmccay commented on a diff in pull request #5352: HADOOP-18618 : Support custom property for credential provider.

["lmccay (via GitHub)" <gi...@apache.org>]

lmccay commented on code in PR #5352:
URL: https://github.com/apache/hadoop/pull/5352#discussion_r1098032159


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:
##########
@@ -2405,6 +2405,30 @@ public char[] getPassword(String name) throws IOException {
     return pass;
   }
 
+  /**
+   * Get the value for a known password configuration element.
+   * In order to enable the elimination of clear text passwords in config,
+   * this method attempts to resolve the property name as an alias through
+   * the CredentialProvider API and conditionally fallsback to config. This
+   * method accept external provider property name.
+   * @param name property name
+   * @param providerKey provider property name
+   * @return password
+   * @throws IOException when error in fetching password
+   */
+  public char[] getPassword(String name, String providerKey)

Review Comment:
   This is an overloaded method with the same name and just an extra argument. I think keeping the same name here is fine as the change isn't adding the fallback to config semantics just the argument for providerKey so that it can be customized instead of use the default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org