You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/03/11 02:47:44 UTC

Review Request 19002: Restart All does not respect the maintenance state on the host component

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19002/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Sumit Mohanty.


Bugs: AMBARI-5010
    https://issues.apache.org/jira/browse/AMBARI-5010


Repository: ambari


Description
-------

HDFS (non-MM).
Had one DN (non-MM) and one DN (MM).
HDFS Start and Stop operations skip the DN in MM (as designed), but Restart All does not.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java abd82ac 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c2192d0 

Diff: https://reviews.apache.org/r/19002/diff/


Testing
-------


Thanks,

Sid Wagle


Re: Review Request 19002: Restart All does not respect the maintenance state on the host component

Posted by Sid Wagle <sw...@hortonworks.com>.

> On March 11, 2014, 1:56 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java, line 235
> > <https://reviews.apache.org/r/19002/diff/1/?file=515851#file515851line235>
> >
> >     If one issues RESTART directly on one hostcomponent it will not work. But we allow Start and Stop.

Does it makes sense to support Restart behavior at service and component level / beside host component, using recently added Resource filter support?


- Sid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19002/#review36747
-----------------------------------------------------------


On March 11, 2014, 1:47 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19002/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 1:47 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5010
>     https://issues.apache.org/jira/browse/AMBARI-5010
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS (non-MM).
> Had one DN (non-MM) and one DN (MM).
> HDFS Start and Stop operations skip the DN in MM (as designed), but Restart All does not.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java abd82ac 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c2192d0 
> 
> Diff: https://reviews.apache.org/r/19002/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 19002: Restart All does not respect the maintenance state on the host component

Posted by Nate Cole <nc...@hortonworks.com>.

> On March 10, 2014, 9:56 p.m., Sumit Mohanty wrote:
> >

Agree with Sumit. You should be able to issue a restart on the HostComponent even if it is in Maintenance.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19002/#review36747
-----------------------------------------------------------


On March 10, 2014, 9:47 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19002/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 9:47 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5010
>     https://issues.apache.org/jira/browse/AMBARI-5010
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS (non-MM).
> Had one DN (non-MM) and one DN (MM).
> HDFS Start and Stop operations skip the DN in MM (as designed), but Restart All does not.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java abd82ac 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c2192d0 
> 
> Diff: https://reviews.apache.org/r/19002/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 19002: Restart All does not respect the maintenance state on the host component

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19002/#review36747
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
<https://reviews.apache.org/r/19002/#comment67934>

    If one issues RESTART directly on one hostcomponent it will not work. But we allow Start and Stop.


- Sumit Mohanty


On March 11, 2014, 1:47 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19002/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 1:47 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5010
>     https://issues.apache.org/jira/browse/AMBARI-5010
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS (non-MM).
> Had one DN (non-MM) and one DN (MM).
> HDFS Start and Stop operations skip the DN in MM (as designed), but Restart All does not.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java abd82ac 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c2192d0 
> 
> Diff: https://reviews.apache.org/r/19002/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>