You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Erik Abele <er...@codefaktor.de> on 2003/02/28 21:44:53 UTC
[PATCH] Re: Apache 2.0 download problem
Greg Ames wrote:
> Erik Abele wrote:
>
>> Therefore I sent the attached patch some days ago ;-)
>
> Patch applied and that directory cvs up'd on daedalus. Thanks, Erik.
>
> What I didn't do (and your patch didn't do either) is change the
> reference in README.html to a "small patch for a small problem" pointing to
> apache_2.0.43-win9x-x86-apr-patch.zip . I don't know for certain if
> that is relevant for .44, but there is a .44 patch with that naming
> convention, so maybe there is another small problem. Could someone who
> knows for sure what's going on here please do whatever is appropriate?
My patch didn't include it because it was already correct :-)
It said '...is called <code>apache_2.0.44-win9x-x86-apr-patch.zip</code>' which is correct (the appropriate file is there, see also Joshua's commit -> r1.32).
Now it says: '...is called <code>apache_2.0.43-win9x-x86-apr-patch.zip</code>' which is not correct IMHO, there is no file with such a name.
Find below another patch to get it finally right (also linked to the mentioned patch for clarity)...
cheers,
Erik
> Thanks,
> Greg
>
Index: README.html
===================================================================
RCS file: /home/cvs/httpd-dist/binaries/win32/README.html,v
retrieving revision 1.33
diff -u -r1.33 README.html
--- README.html 28 Feb 2003 17:13:27 -0000 1.33
+++ README.html 28 Feb 2003 20:35:35 -0000
@@ -93,9 +93,9 @@
<p>Due to a small problem in this release, Win95/98/ME users must
download, in addition to the regular distribution, a small patch file
containing an updated <code>bin/libapr.dll</code> file. The file
-is called <code>apache_2.0.43-win9x-x86-apr-patch.zip</code>
-and should be extracted from the root of your Apache installation.</p>
-
+is called <a href="apache_2.0.44-win9x-x86-apr-patch.zip"
+><code>apache_2.0.44-win9x-x86-apr-patch.zip</code></a> and should be
+extracted from the root of your Apache installation.</p>
<p>A full setup package (.exe) containing the Win9x/WinNT Microsoft System
Installer installer is now available. If the Microsoft System Installer
Re: [PATCH] Re: Apache 2.0 download problem
Posted by Erik Abele <er...@apache.org>.
Greg Ames wrote:
> D'oh! I must have fat fingered it somehow. Sorry.
>
> (writes 50 times on the whiteboard: I will do "cvs diff" before "cvs commit"
> I will do "cvs diff" before "cvs commit"
> I will do "cvs diff" before "cvs commit"
> etc)
Hehe, recently I needed three attempts to get a simple two-line commit right :->
> OK, it should be correct on daedalus now. Thanks for the review and for
> the second patch.
great, thanks too.
cheers,
Erik
Re: [PATCH] Re: Apache 2.0 download problem
Posted by Greg Ames <gr...@apache.org>.
Erik Abele wrote:
> Greg Ames wrote:
>> Patch applied and that directory cvs up'd on daedalus. Thanks, Erik.
>>
>> What I didn't do (and your patch didn't do either) is change the
>> reference in README.html to a "small patch for a small problem"
>> pointing to
>> apache_2.0.43-win9x-x86-apr-patch.zip . I don't know for certain if
>> that is relevant for .44, but there is a .44 patch with that naming
>> convention, so maybe there is another small problem. Could someone
>> who knows for sure what's going on here please do whatever is
>> appropriate?
>
>
> My patch didn't include it because it was already correct :-)
D'oh! I must have fat fingered it somehow. Sorry.
(writes 50 times on the whiteboard: I will do "cvs diff" before "cvs commit"
I will do "cvs diff" before "cvs commit"
I will do "cvs diff" before "cvs commit"
etc)
OK, it should be correct on daedalus now. Thanks for the review and for the
second patch.
Greg