You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/11 14:31:04 UTC

[GitHub] [airflow] subkanthi commented on a change in pull request #20190: Fix mypy providers

subkanthi commented on a change in pull request #20190:
URL: https://github.com/apache/airflow/pull/20190#discussion_r767159816



##########
File path: airflow/providers/asana/hooks/asana.py
##########
@@ -23,7 +23,7 @@
 from asana.error import NotFoundError
 
 try:
-    from functools import cached_property
+    from functools import cached_property  # type: ignore

Review comment:
       `if sys.version_info >= (3, 8):
       from functools import cached_property
   else:
       from cached_property import cached_property`
   The sys.version_info didnt fix the mypy error for me(Im trying in breeze), should I be adding the # type: ignore to the sys.version_info code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org