You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/28 14:57:51 UTC

[GitHub] [airflow] potiuk opened a new pull request #13341: Revert "Support google-cloud-tasks>=2.0.0 (#13334)"

potiuk opened a new pull request #13341:
URL: https://github.com/apache/airflow/pull/13341


   This reverts commit 1f712219fa8971d98bc486896603ce8109c42844.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #13341: Revert "Support google-cloud-tasks>=2.0.0 (#13334)"

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13341:
URL: https://github.com/apache/airflow/pull/13341#issuecomment-751833286


   I don't see a public discussion about it. Can you tell a little more about this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #13341: Revert "Support google-cloud-tasks>=2.0.0 (#13334)"

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13341:
URL: https://github.com/apache/airflow/pull/13341#issuecomment-751845745


   I also just merged #13345  which should be helping in case of upgrade of dependencies also for production image.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #13341: Revert "Support google-cloud-tasks>=2.0.0 (#13334)"

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13341:
URL: https://github.com/apache/airflow/pull/13341#issuecomment-751845282


   Sure. There was a pip-check problem in master in the prod image check (#13329 which was merged just before this one) so we had to revert it it un-break the master. Indeed it lacked explanation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek merged pull request #13341: Revert "Support google-cloud-tasks>=2.0.0 (#13334)"

Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #13341:
URL: https://github.com/apache/airflow/pull/13341


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #13341: Revert "Support google-cloud-tasks>=2.0.0 (#13334)"

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13341:
URL: https://github.com/apache/airflow/pull/13341#issuecomment-751845282


   Sure. There was a pip-check problem in master in the prod image check (which was merged just before this one) so we had to revert it it un-break the master. Indeed it lacked explanation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj edited a comment on pull request #13341: Revert "Support google-cloud-tasks>=2.0.0 (#13334)"

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #13341:
URL: https://github.com/apache/airflow/pull/13341#issuecomment-751833286


   I don't see a public discussion about this change. Can you tell a little more about this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org