[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7619: Oauth go dependency change

["zrhoffman (via GitHub)" <gi...@apache.org>]

zrhoffman commented on code in PR #7619:
URL: https://github.com/apache/trafficcontrol/pull/7619#discussion_r1256501311


##########
dev/traffic_ops/cdn.json:
##########
@@ -10,6 +10,7 @@
 		"log_location_event": "stdout",
 		"whitelisted_oauth_urls": [],
 		"oauth_client_secret": "",
+		"oauth_user_attribute": "unique_name",

Review Comment:
   >> Would these also need to be added to the ansible main.yml file?
   >>
   > @zrhoffman do we need it there?
   
   The Traffic Ops Ansible role doesn't yet have OAuth stuff on the ATC master branch. @dsouza93 is adding it in [`dsouza93:lab_oath](https://github.com/dsouza93/trafficcontrol/commits/lab_oath) (but has not PRed it yet).
   
   So, adding it in #7619 is not really possible without creating conflicts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org