Re: [PR] parquet: Allow setting parquet rowgroup row count limit [iceberg]

["wombatu-kun (via GitHub)" <gi...@apache.org>]

wombatu-kun commented on code in PR #16317:
URL: https://github.com/apache/iceberg/pull/16317#discussion_r3361792375


##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -105,6 +106,38 @@ public void testRowGroupSizeConfigurableWithWriter() throws IOException {
     }
   }
 
+  @Test
+  public void testRowGroupRowLimitConfigurable() throws IOException {

Review Comment:
   New test methods drop the `test` prefix per AGENTS.md:141 (`@Test`, no `test` prefix); the two most recent tests in this same file already follow it (`timestampNanoFilterRespectsNanoseconds`, `timestamptzNanoFilterAcrossTimezones`). Rename to `rowGroupRowLimitConfigurable`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org