[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35626: [SPARK-38240][SQL][FOLLOW-UP] Make RuntimeReplaceableAggregate as an add-on of RuntimeReplaceable

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #35626:
URL: https://github.com/apache/spark/pull/35626#discussion_r813203156



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala
##########
@@ -34,8 +34,11 @@ import org.apache.spark.sql.types.{AbstractDataType, BooleanType}
   """,
   group = "agg_funcs",
   since = "3.0.0")
-case class CountIf(child: Expression) extends RuntimeReplaceableAggregate
-  with ImplicitCastInputTypes with UnaryLike[Expression] {
+case class CountIf(child: Expression)
+    extends ReplaceableAggregateFunction
+    with RuntimeReplaceable
+    with ImplicitCastInputTypes
+    with UnaryLike[Expression] {

Review comment:
       Ur, is the internal Databricks Scala style guide changed, @HyukjinKwon ? In the community, it's still `2-space` for `extends` and `with`.
   - https://github.com/databricks/scala-style-guide

##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/RegrCount.scala
##########
@@ -37,7 +37,10 @@ import org.apache.spark.sql.types.{AbstractDataType, NumericType}
   group = "agg_funcs",
   since = "3.3.0")
 case class RegrCount(left: Expression, right: Expression)
-  extends RuntimeReplaceableAggregate with ImplicitCastInputTypes with BinaryLike[Expression] {
+    extends ReplaceableAggregateFunction
+    with RuntimeReplaceable
+    with ImplicitCastInputTypes
+    with BinaryLike[Expression] {

Review comment:
       ditto.

##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/boolAggregates.scala
##########
@@ -34,8 +34,10 @@ import org.apache.spark.sql.types._
   """,
   group = "agg_funcs",
   since = "3.0.0")
-case class BoolAnd(child: Expression) extends RuntimeReplaceableAggregate
-  with ImplicitCastInputTypes with UnaryLike[Expression] {
+case class BoolAnd(child: Expression)
+    extends ReplaceableAggregateFunction
+    with RuntimeReplaceable
+    with ImplicitCastInputTypes with UnaryLike[Expression] {

Review comment:
       ditto.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org