You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/17 23:52:45 UTC

[GitHub] ayudovin commented on a change in pull request #23569: [SPARK-25713][Core] - adding copy for ColumnArray

ayudovin commented on a change in pull request #23569: [SPARK-25713][Core] - adding copy for ColumnArray
URL: https://github.com/apache/spark/pull/23569#discussion_r248885211
 
 

 ##########
 File path: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarArray.java
 ##########
 @@ -46,7 +47,33 @@ public int numElements() {
 
   @Override
   public ArrayData copy() {
 
 Review comment:
   It’s overrided  methods, I’m not sure that I can change a signature of this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org