You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@flex.apache.org by jude <fl...@gmail.com> on 2016/03/13 06:35:00 UTC
Re: Undo and redo in TLF
It looks like redo does work but it is using CTRL+Y or CMD+Y on Mac. I'm
pretty sure it was CMD+Z for Undo and CMD+SHIFT+Z for Redo. Does anyone
else recall this it working with this key combination?
On Tue, Jan 26, 2016 at 12:54 PM, jude <fl...@gmail.com> wrote:
> Yeah, I'll come up with some more test cases.
> On Jan 24, 2016 1:44 AM, "Harbs" <ha...@gmail.com> wrote:
>
>> Jude,
>>
>> Can you test this against different Flex builds? I wonder if there was
>> some side effect of TLF changes.
>>
>> FWIW, redo works for me in the current build using raw TLF, but I have
>> not tried with Spark components.
>>
>> On Jan 16, 2016, at 3:22 AM, jude <fl...@gmail.com> wrote:
>>
>> > I remember it working in previous versions. I don't think it was
>> introduced
>> > in 4.15. I'm wondering if it was introduced in a recent AIR or Flash
>> > Player. Did it work for you?
>> >
>> > On Fri, Jan 15, 2016 at 12:47 AM, Justin Mclean <
>> justin@classsoftware.com>
>> > wrote:
>> >
>> >> Hi,
>> >>
>> >>> Does undo and more importantly redo work for everyone else?
>> >>
>> >> Does it work in previous versions? i.e. is this a regression or an
>> issue
>> >> that has existed for a while?
>> >>
>> >> Thanks,
>> >> Justin
>>
>>
Re: Undo and redo in TLF
Posted by jude <fl...@gmail.com>.
I like it. If I commit this fix as is it will enable redo via CTRL+ Shift+Z
on Windows and Linux. If that's ok, or if I don't hear any response I'll go
ahead and commit the change.
CTRL+y will still perform redo. We'll have two ways to perform redo with
Spark / TLF based controls.
On Mar 18, 2016 7:32 AM, "Harbs" <ha...@gmail.com> wrote:
> How do you like that? It looks like I did commit that code...
>
> I wonder if something changed in Flash player. Either way, feel free to
> add in a fix.
>
> On Mar 14, 2016, at 8:01 AM, jude <fl...@gmail.com> wrote:
>
> > It looks like there's already code in EditManager to handle CMD+SHIFT+Z
> but
> > it's not hitting it because it's checking for lowercase z. The shift key
> > makes it uppercase so we need to check for character code 90 too.
> >
> > The following code in the EditManager class at line 307 adds a test for
> > case 90. http://pastebin.com/gwP1WiAj
> >
> >
> > On Sun, Mar 13, 2016 at 8:21 AM, Harbs <ha...@gmail.com> wrote:
> >
> >> No. I think that was how it’s always worked. I was going to fix it so
> >> cmd/shift/z worked on Mac, but I don’t think that ever happened.
> >>
> >> On Mar 13, 2016, at 7:35 AM, jude <fl...@gmail.com> wrote:
> >>
> >>> It looks like redo does work but it is using CTRL+Y or CMD+Y on Mac.
> I'm
> >>> pretty sure it was CMD+Z for Undo and CMD+SHIFT+Z for Redo. Does anyone
> >>> else recall this it working with this key combination?
> >>>
> >>> On Tue, Jan 26, 2016 at 12:54 PM, jude <fl...@gmail.com>
> wrote:
> >>>
> >>>> Yeah, I'll come up with some more test cases.
> >>>> On Jan 24, 2016 1:44 AM, "Harbs" <ha...@gmail.com> wrote:
> >>>>
> >>>>> Jude,
> >>>>>
> >>>>> Can you test this against different Flex builds? I wonder if there
> was
> >>>>> some side effect of TLF changes.
> >>>>>
> >>>>> FWIW, redo works for me in the current build using raw TLF, but I
> have
> >>>>> not tried with Spark components.
> >>>>>
> >>>>> On Jan 16, 2016, at 3:22 AM, jude <fl...@gmail.com> wrote:
> >>>>>
> >>>>>> I remember it working in previous versions. I don't think it was
> >>>>> introduced
> >>>>>> in 4.15. I'm wondering if it was introduced in a recent AIR or Flash
> >>>>>> Player. Did it work for you?
> >>>>>>
> >>>>>> On Fri, Jan 15, 2016 at 12:47 AM, Justin Mclean <
> >>>>> justin@classsoftware.com>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>>> Does undo and more importantly redo work for everyone else?
> >>>>>>>
> >>>>>>> Does it work in previous versions? i.e. is this a regression or an
> >>>>> issue
> >>>>>>> that has existed for a while?
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>> Justin
> >>>>>
> >>>>>
> >>
> >>
>
>
Re: Undo and redo in TLF
Posted by Harbs <ha...@gmail.com>.
How do you like that? It looks like I did commit that code...
I wonder if something changed in Flash player. Either way, feel free to add in a fix.
On Mar 14, 2016, at 8:01 AM, jude <fl...@gmail.com> wrote:
> It looks like there's already code in EditManager to handle CMD+SHIFT+Z but
> it's not hitting it because it's checking for lowercase z. The shift key
> makes it uppercase so we need to check for character code 90 too.
>
> The following code in the EditManager class at line 307 adds a test for
> case 90. http://pastebin.com/gwP1WiAj
>
>
> On Sun, Mar 13, 2016 at 8:21 AM, Harbs <ha...@gmail.com> wrote:
>
>> No. I think that was how it’s always worked. I was going to fix it so
>> cmd/shift/z worked on Mac, but I don’t think that ever happened.
>>
>> On Mar 13, 2016, at 7:35 AM, jude <fl...@gmail.com> wrote:
>>
>>> It looks like redo does work but it is using CTRL+Y or CMD+Y on Mac. I'm
>>> pretty sure it was CMD+Z for Undo and CMD+SHIFT+Z for Redo. Does anyone
>>> else recall this it working with this key combination?
>>>
>>> On Tue, Jan 26, 2016 at 12:54 PM, jude <fl...@gmail.com> wrote:
>>>
>>>> Yeah, I'll come up with some more test cases.
>>>> On Jan 24, 2016 1:44 AM, "Harbs" <ha...@gmail.com> wrote:
>>>>
>>>>> Jude,
>>>>>
>>>>> Can you test this against different Flex builds? I wonder if there was
>>>>> some side effect of TLF changes.
>>>>>
>>>>> FWIW, redo works for me in the current build using raw TLF, but I have
>>>>> not tried with Spark components.
>>>>>
>>>>> On Jan 16, 2016, at 3:22 AM, jude <fl...@gmail.com> wrote:
>>>>>
>>>>>> I remember it working in previous versions. I don't think it was
>>>>> introduced
>>>>>> in 4.15. I'm wondering if it was introduced in a recent AIR or Flash
>>>>>> Player. Did it work for you?
>>>>>>
>>>>>> On Fri, Jan 15, 2016 at 12:47 AM, Justin Mclean <
>>>>> justin@classsoftware.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>>> Does undo and more importantly redo work for everyone else?
>>>>>>>
>>>>>>> Does it work in previous versions? i.e. is this a regression or an
>>>>> issue
>>>>>>> that has existed for a while?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Justin
>>>>>
>>>>>
>>
>>
Re: Undo and redo in TLF
Posted by Alex Harui <ah...@adobe.com>.
You are a committer so you can just make the change.
-Alex
On 3/15/16, 6:38 PM, "jude" <fl...@gmail.com> wrote:
>I forgot to ask, should I submit a bug report for this? With the code
>patch
>above, if we add the case for uppercase Z then non Mac operating systems
>we
>would be responding to CTRL+Shift+z as well. They would still respond to
>CTRL+y or we could limit CTRL+Shift+z by adding a check for isMac when
>shiftKey is true.
>
>The question is, do any Windows or Linux programs use or respond to
>CTRL+SHIFT+Z?
>
>On Sun, Mar 13, 2016 at 11:01 PM, jude <fl...@gmail.com> wrote:
>
>> It looks like there's already code in EditManager to handle CMD+SHIFT+Z
>> but it's not hitting it because it's checking for lowercase z. The shift
>> key makes it uppercase so we need to check for character code 90 too.
>>
>> The following code in the EditManager class at line 307 adds a test for
>> case 90. http://pastebin.com/gwP1WiAj
>>
>>
>> On Sun, Mar 13, 2016 at 8:21 AM, Harbs <ha...@gmail.com> wrote:
>>
>>> No. I think that was how it’s always worked. I was going to fix it so
>>> cmd/shift/z worked on Mac, but I don’t think that ever happened.
>>>
>>> On Mar 13, 2016, at 7:35 AM, jude <fl...@gmail.com> wrote:
>>>
>>> > It looks like redo does work but it is using CTRL+Y or CMD+Y on Mac.
>>>I'm
>>> > pretty sure it was CMD+Z for Undo and CMD+SHIFT+Z for Redo. Does
>>>anyone
>>> > else recall this it working with this key combination?
>>> >
>>> > On Tue, Jan 26, 2016 at 12:54 PM, jude <fl...@gmail.com>
>>>wrote:
>>> >
>>> >> Yeah, I'll come up with some more test cases.
>>> >> On Jan 24, 2016 1:44 AM, "Harbs" <ha...@gmail.com> wrote:
>>> >>
>>> >>> Jude,
>>> >>>
>>> >>> Can you test this against different Flex builds? I wonder if there
>>>was
>>> >>> some side effect of TLF changes.
>>> >>>
>>> >>> FWIW, redo works for me in the current build using raw TLF, but I
>>>have
>>> >>> not tried with Spark components.
>>> >>>
>>> >>> On Jan 16, 2016, at 3:22 AM, jude <fl...@gmail.com> wrote:
>>> >>>
>>> >>>> I remember it working in previous versions. I don't think it was
>>> >>> introduced
>>> >>>> in 4.15. I'm wondering if it was introduced in a recent AIR or
>>>Flash
>>> >>>> Player. Did it work for you?
>>> >>>>
>>> >>>> On Fri, Jan 15, 2016 at 12:47 AM, Justin Mclean <
>>> >>> justin@classsoftware.com>
>>> >>>> wrote:
>>> >>>>
>>> >>>>> Hi,
>>> >>>>>
>>> >>>>>> Does undo and more importantly redo work for everyone else?
>>> >>>>>
>>> >>>>> Does it work in previous versions? i.e. is this a regression or
>>>an
>>> >>> issue
>>> >>>>> that has existed for a while?
>>> >>>>>
>>> >>>>> Thanks,
>>> >>>>> Justin
>>> >>>
>>> >>>
>>>
>>>
>>
Re: Undo and redo in TLF
Posted by jude <fl...@gmail.com>.
I forgot to ask, should I submit a bug report for this? With the code patch
above, if we add the case for uppercase Z then non Mac operating systems we
would be responding to CTRL+Shift+z as well. They would still respond to
CTRL+y or we could limit CTRL+Shift+z by adding a check for isMac when
shiftKey is true.
The question is, do any Windows or Linux programs use or respond to
CTRL+SHIFT+Z?
On Sun, Mar 13, 2016 at 11:01 PM, jude <fl...@gmail.com> wrote:
> It looks like there's already code in EditManager to handle CMD+SHIFT+Z
> but it's not hitting it because it's checking for lowercase z. The shift
> key makes it uppercase so we need to check for character code 90 too.
>
> The following code in the EditManager class at line 307 adds a test for
> case 90. http://pastebin.com/gwP1WiAj
>
>
> On Sun, Mar 13, 2016 at 8:21 AM, Harbs <ha...@gmail.com> wrote:
>
>> No. I think that was how it’s always worked. I was going to fix it so
>> cmd/shift/z worked on Mac, but I don’t think that ever happened.
>>
>> On Mar 13, 2016, at 7:35 AM, jude <fl...@gmail.com> wrote:
>>
>> > It looks like redo does work but it is using CTRL+Y or CMD+Y on Mac. I'm
>> > pretty sure it was CMD+Z for Undo and CMD+SHIFT+Z for Redo. Does anyone
>> > else recall this it working with this key combination?
>> >
>> > On Tue, Jan 26, 2016 at 12:54 PM, jude <fl...@gmail.com> wrote:
>> >
>> >> Yeah, I'll come up with some more test cases.
>> >> On Jan 24, 2016 1:44 AM, "Harbs" <ha...@gmail.com> wrote:
>> >>
>> >>> Jude,
>> >>>
>> >>> Can you test this against different Flex builds? I wonder if there was
>> >>> some side effect of TLF changes.
>> >>>
>> >>> FWIW, redo works for me in the current build using raw TLF, but I have
>> >>> not tried with Spark components.
>> >>>
>> >>> On Jan 16, 2016, at 3:22 AM, jude <fl...@gmail.com> wrote:
>> >>>
>> >>>> I remember it working in previous versions. I don't think it was
>> >>> introduced
>> >>>> in 4.15. I'm wondering if it was introduced in a recent AIR or Flash
>> >>>> Player. Did it work for you?
>> >>>>
>> >>>> On Fri, Jan 15, 2016 at 12:47 AM, Justin Mclean <
>> >>> justin@classsoftware.com>
>> >>>> wrote:
>> >>>>
>> >>>>> Hi,
>> >>>>>
>> >>>>>> Does undo and more importantly redo work for everyone else?
>> >>>>>
>> >>>>> Does it work in previous versions? i.e. is this a regression or an
>> >>> issue
>> >>>>> that has existed for a while?
>> >>>>>
>> >>>>> Thanks,
>> >>>>> Justin
>> >>>
>> >>>
>>
>>
>
Re: Undo and redo in TLF
Posted by jude <fl...@gmail.com>.
It looks like there's already code in EditManager to handle CMD+SHIFT+Z but
it's not hitting it because it's checking for lowercase z. The shift key
makes it uppercase so we need to check for character code 90 too.
The following code in the EditManager class at line 307 adds a test for
case 90. http://pastebin.com/gwP1WiAj
On Sun, Mar 13, 2016 at 8:21 AM, Harbs <ha...@gmail.com> wrote:
> No. I think that was how it’s always worked. I was going to fix it so
> cmd/shift/z worked on Mac, but I don’t think that ever happened.
>
> On Mar 13, 2016, at 7:35 AM, jude <fl...@gmail.com> wrote:
>
> > It looks like redo does work but it is using CTRL+Y or CMD+Y on Mac. I'm
> > pretty sure it was CMD+Z for Undo and CMD+SHIFT+Z for Redo. Does anyone
> > else recall this it working with this key combination?
> >
> > On Tue, Jan 26, 2016 at 12:54 PM, jude <fl...@gmail.com> wrote:
> >
> >> Yeah, I'll come up with some more test cases.
> >> On Jan 24, 2016 1:44 AM, "Harbs" <ha...@gmail.com> wrote:
> >>
> >>> Jude,
> >>>
> >>> Can you test this against different Flex builds? I wonder if there was
> >>> some side effect of TLF changes.
> >>>
> >>> FWIW, redo works for me in the current build using raw TLF, but I have
> >>> not tried with Spark components.
> >>>
> >>> On Jan 16, 2016, at 3:22 AM, jude <fl...@gmail.com> wrote:
> >>>
> >>>> I remember it working in previous versions. I don't think it was
> >>> introduced
> >>>> in 4.15. I'm wondering if it was introduced in a recent AIR or Flash
> >>>> Player. Did it work for you?
> >>>>
> >>>> On Fri, Jan 15, 2016 at 12:47 AM, Justin Mclean <
> >>> justin@classsoftware.com>
> >>>> wrote:
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>>> Does undo and more importantly redo work for everyone else?
> >>>>>
> >>>>> Does it work in previous versions? i.e. is this a regression or an
> >>> issue
> >>>>> that has existed for a while?
> >>>>>
> >>>>> Thanks,
> >>>>> Justin
> >>>
> >>>
>
>
Re: Undo and redo in TLF
Posted by Harbs <ha...@gmail.com>.
No. I think that was how it’s always worked. I was going to fix it so cmd/shift/z worked on Mac, but I don’t think that ever happened.
On Mar 13, 2016, at 7:35 AM, jude <fl...@gmail.com> wrote:
> It looks like redo does work but it is using CTRL+Y or CMD+Y on Mac. I'm
> pretty sure it was CMD+Z for Undo and CMD+SHIFT+Z for Redo. Does anyone
> else recall this it working with this key combination?
>
> On Tue, Jan 26, 2016 at 12:54 PM, jude <fl...@gmail.com> wrote:
>
>> Yeah, I'll come up with some more test cases.
>> On Jan 24, 2016 1:44 AM, "Harbs" <ha...@gmail.com> wrote:
>>
>>> Jude,
>>>
>>> Can you test this against different Flex builds? I wonder if there was
>>> some side effect of TLF changes.
>>>
>>> FWIW, redo works for me in the current build using raw TLF, but I have
>>> not tried with Spark components.
>>>
>>> On Jan 16, 2016, at 3:22 AM, jude <fl...@gmail.com> wrote:
>>>
>>>> I remember it working in previous versions. I don't think it was
>>> introduced
>>>> in 4.15. I'm wondering if it was introduced in a recent AIR or Flash
>>>> Player. Did it work for you?
>>>>
>>>> On Fri, Jan 15, 2016 at 12:47 AM, Justin Mclean <
>>> justin@classsoftware.com>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>>> Does undo and more importantly redo work for everyone else?
>>>>>
>>>>> Does it work in previous versions? i.e. is this a regression or an
>>> issue
>>>>> that has existed for a while?
>>>>>
>>>>> Thanks,
>>>>> Justin
>>>
>>>