You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/03/08 04:34:13 UTC

Review Request 65972: Avoid copying scheduler->executor message data in the master.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65972/
-----------------------------------------------------------

Review request for mesos and Meng Zhu.


Bugs: MESOS-8628
    https://issues.apache.org/jira/browse/MESOS-8628


Repository: mesos


Description
-------

This avoids a copy of the scheduler->executor message for the
v0 message path in the master.


Diffs
-----

  src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb 
  src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35 


Diff: https://reviews.apache.org/r/65972/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Re: Review Request 65972: Avoid copying scheduler->executor message data in the master.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65972/#review198947
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On March 7, 2018, 8:34 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65972/
> -----------------------------------------------------------
> 
> (Updated March 7, 2018, 8:34 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-8628
>     https://issues.apache.org/jira/browse/MESOS-8628
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This avoids a copy of the scheduler->executor message for the
> v0 message path in the master.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb 
>   src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35 
> 
> 
> Diff: https://reviews.apache.org/r/65972/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>