You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datafu.apache.org by Eyal Allweil <ey...@yahoo.com> on 2016/06/05 09:21:39 UTC

Re: Review Request 46701: DATAFU-117 - New UDF - CountDistinctUpTo

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46701/
-----------------------------------------------------------

(Updated June 5, 2016, 9:21 a.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-117 - New UDF - CountDistinctUpTo


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/bags/CountDistinctUpTo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/bags/BagTests.java 28292db 

Diff: https://reviews.apache.org/r/46701/diff/


Testing
-------


Thanks,

Eyal Allweil

Re: Review Request 46701: DATAFU-117 - New UDF - CountDistinctUpTo

Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46701/#review139809
-----------------------------------------------------------


Ship it!




Ship It!

- Matthew Hayes


On June 8, 2016, 1:49 p.m., Eyal Allweil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46701/
> -----------------------------------------------------------
> 
> (Updated June 8, 2016, 1:49 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-117 - New UDF - CountDistinctUpTo
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/bags/CountDistinctUpTo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/bags/BagTests.java 28292db 
> 
> Diff: https://reviews.apache.org/r/46701/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eyal Allweil
> 
>

Re: Review Request 46701: DATAFU-117 - New UDF - CountDistinctUpTo

Posted by Eyal Allweil <ey...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46701/
-----------------------------------------------------------

(Updated June 8, 2016, 1:49 p.m.)


Review request for DataFu.


Changes
-------

Incorporated last remaining comment in new diff


Repository: datafu


Description
-------

DATAFU-117 - New UDF - CountDistinctUpTo


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/bags/CountDistinctUpTo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/bags/BagTests.java 28292db 

Diff: https://reviews.apache.org/r/46701/diff/


Testing
-------


Thanks,

Eyal Allweil