You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/07/23 02:49:23 UTC

[GitHub] [helix] pkuwm commented on pull request #1109: ZkClient should not keep retrying getChildren() due to large number of children

pkuwm commented on pull request #1109:
URL: https://github.com/apache/helix/pull/1109#issuecomment-662793749


   This PR is ready to be merged, approved by @jiajunwang 
   ```
   For ZkClient's getChildren() operation, if there are a large number of children and the response packet size exceeds jute.maxbuffer default value 4MB on zk client side, ZkClient will get a ConnectionLossException and keep retrying connecting to ZK. The consequence is, the infinite retry may cause heavy GC on ZK server and kill ZK server.
   
   This commit implements a workaround to exit retry loop for getChildren() if a large number of children cause connection loss. 
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org