[GitHub] [tvm] masahi opened a new pull request, #13851: [MetaSchedule] Fix for RewriteLayout + AllocateConst when the rank of the rewritten weight doesn't change

["masahi (via GitHub)" <gi...@apache.org>]

masahi opened a new pull request, #13851:
URL: https://github.com/apache/tvm/pull/13851

   Previously, the condition `constant.Shape().size() == index_map->initial_indices.size()` was used to decide if the constant that `TECompiler` finds has its layout write already applied or not. But for 1x1 conv2d case, there seems to be a case where the rank of the weight doesn't change after layout rewriting. For example, (1, 1, 32, 16) -> (16, 4, 2, 4). 
   
   This bug led to the same index map being applied twice on a constant during MS tuning and the final compilation.   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Hzfengsy merged pull request #13851: [MetaSchedule] Fix for RewriteLayout + AllocateConst when the rank of the rewritten weight doesn't change

["Hzfengsy (via GitHub)" <gi...@apache.org>]

Hzfengsy merged PR #13851:
URL: https://github.com/apache/tvm/pull/13851


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13851: [MetaSchedule] Fix for RewriteLayout + AllocateConst when the rank of the rewritten weight doesn't change

["tvm-bot (via GitHub)" <gi...@apache.org>]

tvm-bot commented on PR #13851:
URL: https://github.com/apache/tvm/pull/13851#issuecomment-1405893149

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @elvin-n, @junrushao, @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org