You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/02 09:06:46 UTC
[GitHub] [orc] guiyanakuang opened a new pull request #803: ORC-897: Optimization loop termination condition
guiyanakuang opened a new pull request #803:
URL: https://github.com/apache/orc/pull/803
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
Remove redundant conditions
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Optimization loop termination condition in readerIsCompatible method
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #803:
URL: https://github.com/apache/orc/pull/803#issuecomment-891162685
> BTW, @pgaref . When you click the squash button, GitHub shows you the commit title and body input boxes.
>
> The content of those input boxes came from the contributor's commit. So, you need to copy and past the PR title and PR description into it manually. Then, you can make a correct Apache ORC commit instead of using the user's commit message.
>
> 
Right, in this case I wanted to avoid pasting the code sample above. You are right thought we should keep it consistent.
Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #803:
URL: https://github.com/apache/orc/pull/803#issuecomment-890863817
Before merging, it would be great if we make it sure that these are all instances like this (at least in this file or module), @pgaref .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #803:
URL: https://github.com/apache/orc/pull/803#issuecomment-890863121
Yep, @pgaref . I noticed that and wanted to have it in the PR description. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #803:
URL: https://github.com/apache/orc/pull/803#issuecomment-890878909
Thank you so much for review and approval, @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #803:
URL: https://github.com/apache/orc/pull/803#issuecomment-890974808
Thank you, @pgaref !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #803:
URL: https://github.com/apache/orc/pull/803#issuecomment-890875102
> Before merging, it would be great if we make it sure that these are all instances like this (at least in this file or module), @pgaref .
Sure, all seem to be using firstRoots/nextRoots or first/next length -- happy with the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref merged pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
pgaref merged pull request #803:
URL: https://github.com/apache/orc/pull/803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #803:
URL: https://github.com/apache/orc/pull/803#issuecomment-891159575
BTW, @pgaref . When you click the squash button, GitHub shows you the commit title and body input boxes.
The content of those input boxes came from the contributor's commit. So, you need to copy and past the PR title and PR description into it manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #803:
URL: https://github.com/apache/orc/pull/803#issuecomment-891159575
BTW, @pgaref . When you click the squash button, GitHub shows you the commit title and body input boxes.
The content of those input boxes came from the contributor's commit. So, you need to copy and past the PR title and PR description into it manually. Then, you can make a correct Apache ORC commit instead of using the user's commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #803: ORC-897: Optimization loop termination condition
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #803:
URL: https://github.com/apache/orc/pull/803#issuecomment-890862588
> Thank you for making a PR @guiyanakuang .
>
> Could you elaborate why this is redundant in the PR description?
>
> > Remove redundant conditions
>
> Are these all instances like this?
Guess we already make sure __first.length == next.length__
https://github.com/apache/orc/pull/803/files#diff-4c43c10da88510010bb511ba6e6892bb5ea6cc29be1b0b9d97c3bbaae5d382e2L1039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org