You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/22 09:41:22 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #4141: Support batch delete syntax in fe and add pass the delete infomation to be
yangzhg opened a new pull request #4141:
URL: https://github.com/apache/incubator-doris/pull/4141
## Proposed changes
Part of Issues #4051
Add batch delete synatx support, support the syntax described in Issues #4051
Bring the delete infomation to be
## Types of changes
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Doris's issues](https://github.com/apache/incubator-doris/issues), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related issues ID
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg closed pull request #4141: Support batch delete syntax in fe and add pass the delete infomation to be
Posted by GitBox <gi...@apache.org>.
yangzhg closed pull request #4141:
URL: https://github.com/apache/incubator-doris/pull/4141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4141: Support batch delete syntax in fe and add pass the delete infomation to be
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #4141:
URL: https://github.com/apache/incubator-doris/pull/4141#discussion_r461267976
##########
File path: be/src/exec/broker_scan_node.cpp
##########
@@ -71,6 +71,18 @@ Status BrokerScanNode::init(const TPlanNode& tnode, RuntimeState* state) {
_partition_infos.end(),
compare_part_use_range);
}
+ if (broker_scan_node.__isset.delete_conjuncts) {
+ RETURN_IF_ERROR(Expr::create_expr_trees(
+ _pool, broker_scan_node.delete_conjuncts, &_delete_expr_ctxs));
+ }
+ if (broker_scan_node.__isset.merge_type) {
+ _merge_type = broker_scan_node.merge_type;
+ } else {
+ _merge_type = TMergeType::APPEND;
+ }
+ if (_merge_type != TMergeType::MERGE && _delete_expr_ctxs.size() > 0) {
+ return Status::InvalidArgument("cannot support delete condition in APPEND or DELETE load.");
Review comment:
delete on condition is for MERGE load, APPEND is append all data in this load, DELETE is drop all data in this load, Merge is delete all data match delete condition and append others
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -280,7 +287,11 @@ protected void setOptional(CreateRoutineLoadStmt stmt) throws UserException {
if (stmt.getMaxBatchSize() != -1) {
this.maxBatchSizeBytes = stmt.getMaxBatchSize();
}
+ if (stmt.getExecMemLimit() != -1) {
+ this.execMemLimit = stmt.getExecMemLimit();
Review comment:
execMemLimit in all load's property except routine load, add this just for keeping syntax consist.
##########
File path: fe/fe-core/pom.xml
##########
@@ -458,7 +458,7 @@ under the License.
<!--<cupDefinition>${doris.home}/gensrc/parser/sql_parser.cup</cupDefinition>-->
<className>SqlParser</className>
<symbolsName>SqlParserSymbols</symbolsName>
- <expectedConflicts>6</expectedConflicts>
+ <expectedConflicts>7</expectedConflicts>
Review comment:
this will be 0 after the he
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org