You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/06 02:08:19 UTC
[GitHub] [apisix-dashboard] dickens7 opened a new pull request #970: docs: optimize metrics document
dickens7 opened a new pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970
Optimized docs to add Metrics page Gragana configuration guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #970: docs: optimize metrics document
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970#issuecomment-739443961
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=h1) Report
> Merging [#970](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=desc) (1471243) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c574813eea82edcd6d95a2ea0f8857b736049717?el=desc) (c574813) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #970 +/- ##
=======================================
Coverage 43.49% 43.49%
=======================================
Files 18 18
Lines 1299 1299
=======================================
Hits 565 565
Misses 642 642
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=footer). Last update [c574813...bde009e](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #970: docs: optimize metrics document
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970#discussion_r536955527
##########
File path: docs/USER_GUIDE.zh-CN.md
##########
@@ -23,6 +23,8 @@
## 监控
+> Metrics 页面是以 iframe 方式打开 Grafana， Gragana 以 iframe 打开需要配置 [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding)支持,该值默认为`false` 否则浏览器将无法正常渲染 Grafana 页面
Review comment:
👏🏻
1. Please use comma after `支持` in Chinese;
2. Please add a space before `false`;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #970: docs: optimize metrics document
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970#issuecomment-739443961
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=h1) Report
> Merging [#970](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=desc) (bde009e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c574813eea82edcd6d95a2ea0f8857b736049717?el=desc) (c574813) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #970 +/- ##
=======================================
Coverage 43.49% 43.49%
=======================================
Files 18 18
Lines 1299 1299
=======================================
Hits 565 565
Misses 642 642
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=footer). Last update [c574813...bde009e](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #970: docs: optimize metrics document
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970#issuecomment-739443961
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=h1) Report
> Merging [#970](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=desc) (0831752) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c574813eea82edcd6d95a2ea0f8857b736049717?el=desc) (c574813) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #970 +/- ##
=======================================
Coverage 43.49% 43.49%
=======================================
Files 18 18
Lines 1299 1299
=======================================
Hits 565 565
Misses 642 642
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=footer). Last update [c574813...6326a68](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #970: docs: optimize metrics document
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #970: docs: optimize metrics document
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970#issuecomment-739443961
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=h1) Report
> Merging [#970](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=desc) (331bb67) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c574813eea82edcd6d95a2ea0f8857b736049717?el=desc) (c574813) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #970 +/- ##
=======================================
Coverage 43.49% 43.49%
=======================================
Files 18 18
Lines 1299 1299
=======================================
Hits 565 565
Misses 642 642
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=footer). Last update [c574813...331bb67](https://codecov.io/gh/apache/apisix-dashboard/pull/970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org