You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/02/01 23:48:34 UTC
Re: Review Request 65362: Added a method to increment invalid
scheduler API call counters.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65362/
-----------------------------------------------------------
(Updated Feb. 1, 2018, 3:48 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Added a TODO.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
-------
Added a method to increment invalid scheduler API call counters.
Diffs (updated)
-----
src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381
src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491
src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
Diff: https://reviews.apache.org/r/65362/diff/3/
Changes: https://reviews.apache.org/r/65362/diff/2-3/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 65362: Added a method to increment invalid
scheduler API call counters.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65362/#review197052
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Feb. 1, 2018, 11:48 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65362/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 11:48 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a method to increment invalid scheduler API call counters.
>
>
> Diffs
> -----
>
> src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
> src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381
> src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491
> src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
>
>
> Diff: https://reviews.apache.org/r/65362/diff/3/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65362: Added a method to increment invalid
scheduler API call counters.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65362/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 10:18 p.m.)
Review request for mesos and Greg Mann.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
-------
Added a method to increment invalid scheduler API call counters.
Diffs
-----
src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381
src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491
src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
Diff: https://reviews.apache.org/r/65362/diff/3/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman