[GitHub] erisu commented on a change in pull request #438: Add support for EnableGoogleServicesPlugin

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #438: Add support for EnableGoogleServicesPlugin
URL: https://github.com/apache/cordova-android/pull/438#discussion_r215494090
 
 

 ##########
 File path: bin/templates/project/app/build.gradle
 ##########
 @@ -30,6 +30,7 @@ buildscript {
 
     dependencies {
         classpath 'com.android.tools.build:gradle:3.1.0'
+        classpath 'com.google.gms:google-services:3.2.1'
 
 Review comment:
   Would it be possible to wrap this `classpath` in an if condition, like how the apply is done?
   It would be nice to minimize the amount of downloading of build related libraries if they are not needed.
   
   ```
   if (cdvHelpers.getConfigPreference('EnableGoogleServicesPlugin', 'false').toBoolean()) {
     classpath 'com.google.gms:google-services:3.2.1'
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org