You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/09 00:38:10 UTC

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info 

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6325

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................

IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Followup from Laurel's code reviews, to physically
remove references to Cloudera Manager that were hidden.

Remove a few stray instances of Cloudera Manager that I found
still remaining in the source.

Fix up trailing spaces introduced during earlier
Cloudera Manager-related edits.

Also remove stray 'Cloudera' references, or stale/commented
Cloudera-specific info, noticed near other spots being edited.

Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
---
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_auditing.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_perf_skew.xml
M docs/topics/impala_perf_testing.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_schema_design.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_webui.xml
29 files changed, 114 insertions(+), 828 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/6325/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6325/2/docs/topics/impala_logging.xml
File docs/topics/impala_logging.xml:

PS2, Line 372: Cloudera
Cloudera ref - there's at least one more on this page.


PS2, Line 453: <p>
             :         See
             :         <xref audience="integrated" href="sg_redaction.xml#log_redact"/><xref audience="standalone" href="http://www.cloudera.com/documentation/enterprise/latest/topics/sg_redaction.html" scope="external" format="html"/>
             :         for details about how to enable this feature and set
             :         up the regular expressions to detect and redact sensitive information within SQL statement text.
             :       </p>
This should've been set to hidden and removed -- the content at that link is very strictly geared towards CM. We need clarification on how redaction works with standalone Impala on hadoop. How it can be enabled and what the default setting is.


http://gerrit.cloudera.org:8080/#/c/6325/2/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:

PS2, Line 489: Cloudera
will this continue to be hosted on archive.cloudera? Flagging this because Cloudera was removed from the previous paragraph that talks about this package, but not here.


http://gerrit.cloudera.org:8080/#/c/6325/2/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:

PS2, Line 386: /cloudera/
cloudera repo link to be replaced?


-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................


Patch Set 3:

(3 comments)

Removed a couple more 'Cloudera' instances.

http://gerrit.cloudera.org:8080/#/c/6325/2/docs/topics/impala_logging.xml
File docs/topics/impala_logging.xml:

PS2, Line 372: 
> Cloudera ref - there's at least one more on this page.
Done


http://gerrit.cloudera.org:8080/#/c/6325/2/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:

PS2, Line 489: 
> will this continue to be hosted on archive.cloudera? Flagging this because 
Done


http://gerrit.cloudera.org:8080/#/c/6325/2/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:

PS2, Line 386: /cloudera/
> cloudera repo link to be replaced?
That'll be a discussion topic for the next iteration, not doing this time.


-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................

IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Followup from Laurel's code reviews, to physically
remove references to Cloudera Manager that were hidden.

Remove a few stray instances of Cloudera Manager that I found
still remaining in the source.

Fix up trailing spaces introduced during earlier
Cloudera Manager-related edits.

Also remove stray 'Cloudera' references, or stale/commented
Cloudera-specific info, noticed near other spots being edited.

Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
---
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_auditing.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_perf_skew.xml
M docs/topics/impala_perf_testing.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_schema_design.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_webui.xml
30 files changed, 120 insertions(+), 835 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/6325/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6325/2/docs/topics/impala_logging.xml
File docs/topics/impala_logging.xml:

PS2, Line 453: <p>
             :         See
             :         <xref audience="integrated" href="sg_redaction.xml#log_redact"/><xref audience="standalone" href="http://www.cloudera.com/documentation/enterprise/latest/topics/sg_redaction.html" scope="external" format="html"/>
             :         for details about how to enable this feature and set
             :         up the regular expressions to detect and redact sensitive information within SQL statement text.
             :       </p>
> This should've been set to hidden and removed -- the content at that link i
That'll be an item for the next iteration where we deal with external links.


-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................


IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Followup from Laurel's code reviews, to physically
remove references to Cloudera Manager that were hidden.

Remove a few stray instances of Cloudera Manager that I found
still remaining in the source.

Fix up trailing spaces introduced during earlier
Cloudera Manager-related edits.

Also remove stray 'Cloudera' references, or stale/commented
Cloudera-specific info, noticed near other spots being edited.

Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Reviewed-on: http://gerrit.cloudera.org:8080/6325
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_auditing.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_perf_skew.xml
M docs/topics/impala_perf_testing.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_schema_design.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_webui.xml
30 files changed, 123 insertions(+), 839 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Ambreen Kazi: Looks good to me, but someone else must approve
  John Russell: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................


Patch Set 3:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/66/

-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).

Change subject: IMPALA-3401: [DOCS] Physically remove Cloudera Manager info
......................................................................

IMPALA-3401: [DOCS] Physically remove Cloudera Manager info

Followup from Laurel's code reviews, to physically
remove references to Cloudera Manager that were hidden.

Remove a few stray instances of Cloudera Manager that I found
still remaining in the source.

Fix up trailing spaces introduced during earlier
Cloudera Manager-related edits.

Also remove stray 'Cloudera' references, or stale/commented
Cloudera-specific info, noticed near other spots being edited.

Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
---
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_auditing.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_perf_skew.xml
M docs/topics/impala_perf_testing.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_schema_design.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_webui.xml
30 files changed, 123 insertions(+), 839 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/6325/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc4a84527ae42c39b3717190b6cf669e17fff04b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>