You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/07 23:04:48 UTC
[GitHub] [airflow] ashb opened a new pull request #8775: Correctly restore upstream_task_ids when deserializing Operators
ashb opened a new pull request #8775:
URL: https://github.com/apache/airflow/pull/8775
This test exposed a bug in one of the example dags, that wasn't caught by #6549. That will be a fixed in a separate issue, but it caused the round-trip tests to fail here
Should fix #8720, (but I haven't tested this. I was actually fixing another bug caused by the same place)
(Depends on #8774 for the test rework only. Ignore the first commit in this PR when reviewing for now.)
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #8775: Correctly restore upstream_task_ids when deserializing Operators
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8775:
URL: https://github.com/apache/airflow/pull/8775#issuecomment-626215072
Tested this PR fixes https://github.com/apache/airflow/issues/8720 :
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #8775: Correctly restore upstream_task_ids when deserializing Operators
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #8775:
URL: https://github.com/apache/airflow/pull/8775#discussion_r421843524
##########
File path: airflow/providers/google/cloud/example_dags/example_gcs.py
##########
@@ -126,8 +126,8 @@
)
# [START howto_operator_gcs_delete_bucket]
- delete_bucket_1 = GCSDeleteBucketOperator(task_id="delete_bucket", bucket_name=BUCKET_1)
- delete_bucket_2 = GCSDeleteBucketOperator(task_id="delete_bucket", bucket_name=BUCKET_2)
+ delete_bucket_1 = GCSDeleteBucketOperator(task_id="delete_bucket_1", bucket_name=BUCKET_1)
+ delete_bucket_2 = GCSDeleteBucketOperator(task_id="delete_bucket_2", bucket_name=BUCKET_2)
Review comment:
@potiuk @mik-laj This change should be okay, right? (I can't think of any reason why it wouldn't be)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org