You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Kuhu Shukla (JIRA)" <ji...@apache.org> on 2016/12/14 22:06:58 UTC

[jira] [Created] (HDFS-11246) FSNameSystem#logAuditEvent should be called outside the read or write locks during operations like getContentSummary

Kuhu Shukla created HDFS-11246:
----------------------------------

             Summary: FSNameSystem#logAuditEvent should be called outside the read or write locks during operations like getContentSummary
                 Key: HDFS-11246
                 URL: https://issues.apache.org/jira/browse/HDFS-11246
             Project: Hadoop HDFS
          Issue Type: Bug
    Affects Versions: 2.7.3
            Reporter: Kuhu Shukla
            Assignee: Kuhu Shukla


{code}
    readLock();
    boolean success = true;
    ContentSummary cs;
    try {
      checkOperation(OperationCategory.READ);
      cs = FSDirStatAndListingOp.getContentSummary(dir, src);
    } catch (AccessControlException ace) {
      success = false;
      logAuditEvent(success, operationName, src);
      throw ace;
    } finally {
      readUnlock(operationName);
    }
{code}

It would be nice to have audit logging outside the lock esp. in scenarios where applications hammer a given operation several times. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org