You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2016/03/09 23:20:34 UTC
[GitHub] brooklyn-dist pull request: Include brooklyn-client-cli
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-dist/pull/14
Include brooklyn-client-cli
Merge this after the following are merged:
https://github.com/apache/brooklyn-client/pull/4
https://github.com/apache/brooklyn-server/pull/54
https://github.com/apache/brooklyn-ui/pull/15
https://github.com/apache/brooklyn-docs/pull/25
https://github.com/apache/brooklyn/pull/5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy/brooklyn-dist include-cli
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit 5bc7080a42536d2ce6a109729aaacfe2952796dc
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-19T16:22:10Z
Add brooklyn-client-cli as a dependency.
This will mean that the build includes the archive for the client CLI
in lib/brooklyn, e.g.
lib/brooklyn/org.apache.brooklyn-brooklyn-client-cli-0.9.0-SNAPSHOT-bin.zip
commit fb30a9cbbbdaa7dc27378f27352ba96f58b3f1fa
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-23T14:57:42Z
Include brooklyn-client-cli artifacts
commit f7e8eddc24835f197782ecddfbc1c13f21820851
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-24T21:06:42Z
Fix paths in projects-with-custom-licenses
commit 7d55d53318bd97357b57a4132ebc2a5b7e3602ac
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-25T16:20:58Z
Start of work to add license files for CLI, NOT WORKING YET.
commit 1bf00c1e9405747ffe5b1543d8e62ca8b3fa6774
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-26T12:17:16Z
Updates for license for brooklyn-client, now working.
commit 98389cda4c25099f17b3eb7b9f8b232131996907
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-03-09T21:17:10Z
Add no-go-client profile to avoid including brooklyn-client artifacts.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Include brooklyn-client-cli
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Include brooklyn-client-cli
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/14#discussion_r55653884
--- Diff: dist/licensing/extras-files ---
@@ -1 +1 @@
-../../brooklyn-ui/src/main/license/source-inclusions.yaml:../../brooklyn-server/server-cli/src/main/license/source-inclusions.yaml
+../../brooklyn-ui/src/main/license/source-inclusions.yaml:../../brooklyn-server/server-cli/src/main/license/source-inclusions.yaml:../../brooklyn-client/src/main/license/source-inclusions.yaml
--- End diff --
(not part of this PR but it feels wrong to follow the `/src/main/` structure for a go project and easy to change to put this info into `build/`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Include brooklyn-client-cli
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/14#issuecomment-194765484
looks good; making some tweaks which impact this as described at https://github.com/apache/brooklyn-docs/pull/25#issuecomment-194764886 , will commit those as a follow-up
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---