You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2017/05/02 18:58:14 UTC

[GitHub] spark pull request #17346: [SPARK-19965][SS] DataFrame batch reader may fail...

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17346#discussion_r114396634
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala ---
    @@ -145,6 +147,41 @@ class FileStreamSinkSuite extends StreamTest {
         }
       }
     
    +  test("partitioned writing and batch reading with 'basePath'") {
    +    val inputData = MemoryStream[Int]
    +    val ds = inputData.toDS()
    +
    +    val outputDir = Utils.createTempDir(namePrefix = "stream.output").getCanonicalPath
    +    val checkpointDir = Utils.createTempDir(namePrefix = "stream.checkpoint").getCanonicalPath
    --- End diff --
    
    nit: same as above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org