[jira] [Comment Edited] (FLINK-27367) CAST between INT and DATE is broken

["Jark Wu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-27367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528028#comment-17528028 ] 

Jark Wu edited comment on FLINK-27367 at 4/29/22 7:31 AM:
----------------------------------------------------------

Fixed in 
 - 1.15.1: 3b790d16b731bf6455a793207501a9bd5f0ee2a0
 - master: 631f6891b2d04bd485a6879fa6f424d040eb6610


was (Author: jark):
Fixed in 
 - 1.15.1: 3b790d16b731bf6455a793207501a9bd5f0ee2a0
 - master: TODO

> CAST between INT and DATE is broken
> -----------------------------------
>
>                 Key: FLINK-27367
>                 URL: https://issues.apache.org/jira/browse/FLINK-27367
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.15.0
>            Reporter: Jark Wu
>            Assignee: dalongliu
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.15.1
>
>
> {code:sql}
> SELECT CASE WHEN true THEN cast(1 as int) ELSE cast('2017-12-11 09:30:00' as date) END;
> {code}
> The above code throws the following exception which is supported in the previous version:
> {code}
> org.apache.flink.table.api.ValidationException: SQL validation failed. Unsupported cast from 'INT NOT NULL' to 'DATE NOT NULL'.
> 	at org.apache.flink.table.planner.operations.SqlToOperationConverter.convertValidatedSqlNode(SqlToOperationConverter.java:395)
> 	at org.apache.flink.table.planner.operations.SqlToOperationConverter.convert(SqlToOperationConverter.java:261)
> 	at org.apache.flink.table.planner.delegation.ParserImpl.parse(ParserImpl.java:112)
> 	at org.apache.flink.table.api.internal.TableEnvironmentImpl.sqlQuery(TableEnvironmentImpl.java:680)
> 	at org.apache.flink.table.planner.runtime.utils.BatchTestBase.parseQuery(BatchTestBase.scala:297)
> 	at org.apache.flink.table.planner.runtime.utils.BatchTestBase.check(BatchTestBase.scala:139)
> 	at org.apache.flink.table.planner.runtime.utils.BatchTestBase.checkResult(BatchTestBase.scala:106)
> 	at org.apache.flink.table.planner.runtime.batch.sql.CalcITCase.test2(CalcITCase.scala:92)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> 	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
> 	at org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
> 	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> 	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> 	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> 	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> 	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> 	at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
> 	at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
> 	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
> 	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
> 	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: org.apache.flink.table.planner.codegen.CodeGenException: Unsupported cast from 'INT NOT NULL' to 'DATE NOT NULL'.
> 	at org.apache.flink.table.planner.codegen.calls.ScalarOperatorGens$.generateCast(ScalarOperatorGens.scala:955)
> 	at org.apache.flink.table.planner.codegen.ExprCodeGenerator.generateCallExpression(ExprCodeGenerator.scala:711)
> 	at org.apache.flink.table.planner.codegen.ExprCodeGenerator.visitCall(ExprCodeGenerator.scala:495)
> 	at org.apache.flink.table.planner.codegen.ExprCodeGenerator.visitCall(ExprCodeGenerator.scala:60)
> 	at org.apache.calcite.rex.RexCall.accept(RexCall.java:174)
> 	at org.apache.flink.table.planner.codegen.ExprCodeGenerator.generateExpression(ExprCodeGenerator.scala:159)
> 	at org.apache.flink.table.planner.codegen.ExpressionReducer.$anonfun$reduce$2(ExpressionReducer.scala:79)
> 	at scala.collection.immutable.List.map(List.scala:282)
> 	at org.apache.flink.table.planner.codegen.ExpressionReducer.reduce(ExpressionReducer.scala:79)
> 	at org.apache.calcite.rex.RexSimplify.simplifyCast(RexSimplify.java:2101)
> 	at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:326)
> 	at org.apache.calcite.rex.RexSimplify.simplifyCase(RexSimplify.java:1006)
> 	at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:322)
> 	at org.apache.calcite.rex.RexSimplify.simplifyUnknownAs(RexSimplify.java:287)
> 	at org.apache.calcite.rex.RexSimplify.simplifyPreservingType(RexSimplify.java:226)
> 	at org.apache.calcite.rex.RexSimplify.simplifyPreservingType(RexSimplify.java:221)
> 	at org.apache.calcite.tools.RelBuilder.project_(RelBuilder.java:1456)
> 	at org.apache.calcite.tools.RelBuilder.project(RelBuilder.java:1311)
> 	at org.apache.calcite.tools.RelBuilder.projectNamed(RelBuilder.java:1565)
> 	at org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectList(SqlToRelConverter.java:4248)
> 	at org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:689)
> 	at org.apache.calcite.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:646)
> 	at org.apache.calcite.sql2rel.SqlToRelConverter.convertQueryRecursive(SqlToRelConverter.java:3464)
> 	at org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:572)
> 	at org.apache.flink.table.planner.calcite.FlinkPlannerImpl.rel(FlinkPlannerImpl.java:336)
> 	at org.apache.flink.table.planner.calcite.FlinkPlannerImpl.rel(FlinkPlannerImpl.java:329)
> 	at org.apache.flink.table.planner.operations.SqlToOperationConverter.toQueryOperation(SqlToOperationConverter.java:1370)
> 	at org.apache.flink.table.planner.operations.SqlToOperationConverter.convertSqlQuery(SqlToOperationConverter.java:1318)
> 	at org.apache.flink.table.planner.operations.SqlToOperationConverter.convertValidatedSqlNode(SqlToOperationConverter.java:371)
> 	... 42 more
> {code}
> It seems that the FLINK-24780 drops this support when porting CAST to the new structure.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)