You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/04 13:11:53 UTC

[GitHub] [flink] XComp opened a new pull request #14551: [FLINK-20841][tests] Removed obsolete .gitignore

XComp opened a new pull request #14551:
URL: https://github.com/apache/flink/pull/14551


   ## What is the purpose of the change
   
   The `.gitignore` file is not needed anymore since we're creating the generated source in the `target/` subfolder now.
   
   ## Brief change log
   
   Removed `.gitignore`.
   
   ## Verifying this change
   
   I ran `mvn package` on the `flink-confluent-schema-registry` module.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14551: [FLINK-20841][tests] Removed obsolete .gitignore

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14551:
URL: https://github.com/apache/flink/pull/14551#issuecomment-753973367


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "72ddbf15c96c61fba3b9be2c015937db4e863a60",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "72ddbf15c96c61fba3b9be2c015937db4e863a60",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 72ddbf15c96c61fba3b9be2c015937db4e863a60 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #14551: [FLINK-20841][tests] Removed obsolete .gitignore

Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #14551:
URL: https://github.com/apache/flink/pull/14551#issuecomment-753981210


   > These changes are already in master.
   > [a1f90d7](https://github.com/apache/flink/commit/a1f90d79bde03d9f7c54cb37742e3e418ec1e0e6)
   > [86a9af3](https://github.com/apache/flink/commit/86a9af30d2a4792b8d632174a7e91d052d6aadca)
   
   Closed PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14551: [FLINK-20841][tests] Removed obsolete .gitignore

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14551:
URL: https://github.com/apache/flink/pull/14551#issuecomment-753967376


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 72ddbf15c96c61fba3b9be2c015937db4e863a60 (Fri May 28 07:00:02 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14551: [FLINK-20841][tests] Removed obsolete .gitignore

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14551:
URL: https://github.com/apache/flink/pull/14551#issuecomment-753967376


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 72ddbf15c96c61fba3b9be2c015937db4e863a60 (Mon Jan 04 13:13:29 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #14551: [FLINK-20841][tests] Removed obsolete .gitignore

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14551:
URL: https://github.com/apache/flink/pull/14551#issuecomment-753971157


   These changes are already in master.
   a1f90d79bde03d9f7c54cb37742e3e418ec1e0e6
   86a9af30d2a4792b8d632174a7e91d052d6aadca


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp closed pull request #14551: [FLINK-20841][tests] Removed obsolete .gitignore

Posted by GitBox <gi...@apache.org>.
XComp closed pull request #14551:
URL: https://github.com/apache/flink/pull/14551


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org