[GitHub] [kafka] dejan2609 commented on pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled

["dejan2609 (via GitHub)" <gi...@apache.org>]

dejan2609 commented on PR #13306:
URL: https://github.com/apache/kafka/pull/13306#issuecomment-1445443507

   Got it @ijuma. 
   
   I removed redundant line (as proposed by @chia7712) but I do agree that solution is maybe an overkill, so to say. 
   
   My idea was to prevent tasks (such as `build` and `check`) that depend on spotless plugin related tasks to fail: 
   
   `./gradlew build tiTree` 
   
   ```
   > Task :tiTree
   :build                                                         (org.gradle.api.DefaultTask)
   +--- :assemble                                                 (org.gradle.api.DefaultTask)
   |    `--- :jar                                                 (org.gradle.api.tasks.bundling.Jar)
   |         +--- :classes                                        (org.gradle.api.DefaultTask)
   |         |    +--- :compileJava                               (org.gradle.api.tasks.compile.JavaCompile)
   |         |    `--- :processResources                          (org.gradle.language.jvm.tasks.ProcessResources)
   |         `--- :compileJava                                    (org.gradle.api.tasks.compile.JavaCompile)
   `--- :check                                                    (org.gradle.api.DefaultTask)
        +--- :rat                                                 (org.nosphere.apache.rat.RatTask)
        +--- :spotlessCheck                                       (org.gradle.api.DefaultTask)
        |    `--- :spotlessScalaCheck                             (com.diffplug.gradle.spotless.SpotlessCheck)
        |         `--- :spotlessScala                             (com.diffplug.gradle.spotless.SpotlessTaskImpl)
        |              `--- :spotlessInternalRegisterDependencies (com.diffplug.gradle.spotless.RegisterDependenciesTask)
        `--- :test                                                (org.gradle.api.tasks.testing.Test)
             +--- :classes                                        (org.gradle.api.DefaultTask)
             |    +--- :compileJava                               (org.gradle.api.tasks.compile.JavaCompile)
             |    `--- :processResources                          (org.gradle.language.jvm.tasks.ProcessResources)
             +--- :compileJava                                    (org.gradle.api.tasks.compile.JavaCompile)
             +--- :compileTestJava                                (org.gradle.api.tasks.compile.JavaCompile)
             |    +--- :classes                                   (org.gradle.api.DefaultTask)
             |    |    +--- :compileJava                          (org.gradle.api.tasks.compile.JavaCompile)
             |    |    `--- :processResources                     (org.gradle.language.jvm.tasks.ProcessResources)
             |    `--- :compileJava                               (org.gradle.api.tasks.compile.JavaCompile)
             `--- :testClasses                                    (org.gradle.api.DefaultTask)
                  +--- :compileTestJava                           (org.gradle.api.tasks.compile.JavaCompile)
                  |    +--- :classes                              (org.gradle.api.DefaultTask)
                  |    |    +--- :compileJava                     (org.gradle.api.tasks.compile.JavaCompile)
                  |    |    `--- :processResources                (org.gradle.language.jvm.tasks.ProcessResources)
                  |    `--- :compileJava                          (org.gradle.api.tasks.compile.JavaCompile)
                  `--- :processTestResources                      (org.gradle.language.jvm.tasks.ProcessResources)
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org