You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/30 01:29:32 UTC
[GitHub] [fineract] xurror opened a new pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
xurror opened a new pull request #1309:
URL: https://github.com/apache/fineract/pull/1309
Considering the discussion we had on the mailing list about the way to set up this generation strategy.
I tried setting up an AbstractPersistable class for this but it didn't work out because the IDs for all ~200 entities where being generated by one table and thus the IDs were not controlled, causing even way more trouble than what this change was meant to resolve.
I know there was alot of comments about this being confusing but I am still trying to picture how bad it is to have this applied to just one entity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1309:
URL: https://github.com/apache/fineract/pull/1309#issuecomment-704982021
Hi
Quick search for people who have had a similar problem comes up with this:
https://stackoverflow.com/questions/12429237/eclipselink-returns-entity-with-null-primary-key
In this case it was resolved by setting eclipselink.weaving.internal to "false"
Is this something you've already tried? If not, would it be worth giving it a go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1309:
URL: https://github.com/apache/fineract/pull/1309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1309:
URL: https://github.com/apache/fineract/pull/1309#issuecomment-701882651
Hey @ptuomola @vorburger @awasum any input on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1309:
URL: https://github.com/apache/fineract/pull/1309#issuecomment-704394127
Here comes my concern exactly.
I wasn’t able to resolve the problem with eclipselink cause turns out in
certain cases IDs were not generated fast enough so I constantly got null
pointers exception when trying to persist the entity.
Of all my attempts, having a table of pre-generated IDs was what did the
trick.
On Tue, Oct 6, 2020 at 3:08 PM Michael Vorburger ⛑️ <
notifications@github.com> wrote:
>
>
> My concern here is that, apparently, we would have to do this for EACH
>
>
> Entity (Table), separately? I doubt that's a good idea. If I understood it
>
>
> correctly , this comes out of a problem encountered during the EclipseLink
>
>
> migration. Couldn't we solve whatever problem that was, instead of having
>
>
> to switch GenerationType, per table?
>
>
>
>
>
> >
>
>
>
>
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1309#issuecomment-704294475>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AK5B5DE2PHZEC4RLECAZPD3SJMQHRANCNFSM4QPKIYSA>
> .
>
>
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1309:
URL: https://github.com/apache/fineract/pull/1309#issuecomment-704294475
My concern here is that, apparently, we would have to do this for EACH
Entity (Table), separately? I doubt that's a good idea. If I understood it
correctly , this comes out of a problem encountered during the EclipseLink
migration. Couldn't we solve whatever problem that was, instead of having
to switch GenerationType, per table?
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1309:
URL: https://github.com/apache/fineract/pull/1309#issuecomment-701081124
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1309:
URL: https://github.com/apache/fineract/pull/1309#issuecomment-704228015
Sorry @xurror - not my area of expertise! It's not clear to me why we would need to change the GenerationType for this table - i.e. why doesn't the previous setting work. Do you know?
And re the GenerationType.TABLE - all I can find on the web is recommendations never to use it. Seems like this is slow (which makes sense, you have to keep updating the table) and SEQUENCE does a much better job. Was TABLE the only one that worked for you, and any idea what the performance overhead is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1309:
URL: https://github.com/apache/fineract/pull/1309#issuecomment-705100114
I can try it out.
On Wed, Oct 7, 2020 at 3:39 PM Petri Tuomola <no...@github.com>
wrote:
>
>
> Hi
>
>
> Quick search for people who have had a similar problem comes up with this:
>
>
>
> https://stackoverflow.com/questions/12429237/eclipselink-returns-entity-with-null-primary-key
>
>
> In this case it was resolved by setting eclipselink.weaving.internal to
> "false"
>
>
> Is this something you've already tried? If not, would it be worth giving
> it a go?
>
>
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1309#issuecomment-704982021>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AK5B5DABPWTCWPT3DA5NNFTSJR4SNANCNFSM4QPKIYSA>
> .
>
>
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1309:
URL: https://github.com/apache/fineract/pull/1309#issuecomment-727156666
> Hi
>
> Quick search for people who have had a similar problem comes up with this:
>
> https://stackoverflow.com/questions/12429237/eclipselink-returns-entity-with-null-primary-key
>
> In this case it was resolved by setting eclipselink.weaving.internal to "false"
>
> Is this something you've already tried? If not, would it be worth giving it a go?
Unfortunately, that didn't fix but I'm looking at other solutions. I'm drafting this for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1309: FINERACT-1140 - Adopt GenerationType.TABLE as ID generation strategy [Discussion]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1309:
URL: https://github.com/apache/fineract/pull/1309#issuecomment-744895903
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org