You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/15 14:01:32 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #9685: ARROW-10372: [Dataset][C++][Python][R] Support reading compressed CSV

pitrou commented on a change in pull request #9685:
URL: https://github.com/apache/arrow/pull/9685#discussion_r594360734



##########
File path: cpp/src/arrow/dataset/file_csv_test.cc
##########
@@ -190,5 +208,24 @@ N/A,bar
   }
 }
 
+INSTANTIATE_TEST_SUITE_P(TestUncompressedCsv, TestCsvFileFormat,
+                         ::testing::Values(Compression::UNCOMPRESSED));
+#ifdef ARROW_WITH_BROTLI
+INSTANTIATE_TEST_SUITE_P(TestBrotliCsv, TestCsvFileFormat,
+                         ::testing::Values(Compression::BROTLI));

Review comment:
       Can you also test with bz2 (which is much more likely for compression of CSV files than Brotli)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org