You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/25 08:15:56 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #134: chore: integrate api7/types.
tokers opened a new pull request #134:
URL: https://github.com/apache/apisix-ingress-controller/pull/134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #134: chore: integrate api7/types.
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #134:
URL: https://github.com/apache/apisix-ingress-controller/pull/134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #134: chore: integrate api7/types.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #134:
URL: https://github.com/apache/apisix-ingress-controller/pull/134#issuecomment-751205848
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=h1) Report
> Merging [#134](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=desc) (fdd9e0e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/e58e6d6b518b24fa168dc8e9c04c1cf7997a41e1?el=desc) (e58e6d6) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 34.40% 34.40%
=======================================
Files 28 28
Lines 1212 1212
=======================================
Hits 417 417
Misses 761 761
Partials 34 34
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/annotation.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L2Fubm90YXRpb24uZ28=) | `30.43% <ø> (ø)` | |
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/ingress/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3NlcnZpY2UuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==) | `92.00% <ø> (ø)` | |
| [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | `87.80% <ø> (ø)` | |
| [pkg/seven/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2FwaXNpeC9yb3V0ZS5nbw==) | `31.73% <ø> (ø)` | |
| [pkg/seven/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2FwaXNpeC9zZXJ2aWNlLmdv) | `7.69% <ø> (ø)` | |
| [pkg/seven/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2FwaXNpeC9zc2wuZ28=) | `12.06% <ø> (ø)` | |
| [pkg/seven/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2FwaXNpeC91cHN0cmVhbS5nbw==) | `6.25% <ø> (ø)` | |
| [pkg/seven/state/builder.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL2J1aWxkZXIuZ28=) | `0.00% <ø> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=footer). Last update [e58e6d6...fdd9e0e](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #134: chore: integrate api7/types.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #134:
URL: https://github.com/apache/apisix-ingress-controller/pull/134#issuecomment-751205848
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=h1) Report
> Merging [#134](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=desc) (fdd9e0e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/e58e6d6b518b24fa168dc8e9c04c1cf7997a41e1?el=desc) (e58e6d6) will **decrease** coverage by `0.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 34.40% 33.75% -0.66%
==========================================
Files 28 27 -1
Lines 1212 1185 -27
==========================================
- Hits 417 400 -17
+ Misses 761 756 -5
+ Partials 34 29 -5
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/annotation.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L2Fubm90YXRpb24uZ28=) | `30.43% <ø> (ø)` | |
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/ingress/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3NlcnZpY2UuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==) | `92.00% <ø> (ø)` | |
| [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | `87.80% <ø> (ø)` | |
| [pkg/seven/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2FwaXNpeC9yb3V0ZS5nbw==) | `31.73% <ø> (ø)` | |
| [pkg/seven/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2FwaXNpeC9zZXJ2aWNlLmdv) | `7.69% <ø> (ø)` | |
| [pkg/seven/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2FwaXNpeC9zc2wuZ28=) | `12.06% <ø> (ø)` | |
| [pkg/seven/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2FwaXNpeC91cHN0cmVhbS5nbw==) | `6.25% <ø> (ø)` | |
| [pkg/seven/state/builder.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL2J1aWxkZXIuZ28=) | `0.00% <ø> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=footer). Last update [e58e6d6...fdd9e0e](https://codecov.io/gh/apache/apisix-ingress-controller/pull/134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org