You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/24 02:46:25 UTC
[jira] [Commented] (CB-10942) Cannot for links in that site, if you have
[ https://issues.apache.org/jira/browse/CB-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209563#comment-15209563 ]
ASF GitHub Bot commented on CB-10942:
-------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/211
CB-10942 - Cannot <allow-navigation href="https://foo.bar" /> for lin…
…ks in that site, if you have <allow-intent href="https://*" />
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-10942
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #211
----
commit 43f52799227fc3625f0edaf0a4ed0aa16deb24d7
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-03-24T01:45:04Z
CB-10942 - Cannot <allow-navigation href="https://foo.bar" /> for links in that site, if you have <allow-intent href="https://*" />
----
> Cannot <allow-navigation href="https://foo.bar" /> for links in that site, if you have <allow-intent href="https://*" />
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: CB-10942
> URL: https://issues.apache.org/jira/browse/CB-10942
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
>
> https://github.com/apache/cordova-ios/blob/6221bd7c7f54421a158cd18d1ecb8ee88247db07/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L74
> 1. Re-factor that method so it is testable
> 2. Add Obj-C tests to test this case
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org