[GitHub] [bigtop] evans-ye commented on a change in pull request #851: BIGTOP-3614: allow to change the docker-compose cfg in the provisioner

[GitBox <gi...@apache.org>]

evans-ye commented on a change in pull request #851:
URL: https://github.com/apache/bigtop/pull/851#discussion_r781776837



##########
File path: provisioner/docker/docker-hadoop.sh
##########
@@ -284,12 +293,19 @@ log() {
 }
 
 configure-nexus() {
+    get_nodes
     for node in ${NODES[*]}; do
         docker exec $node bash -c "cd /bigtop-home; ./gradlew -PNEXUS_URL=$1 configure-nexus"
     done
     wait
 }
 
+get_nodes() {
+    if [ -n "$PROVISION_ID" ]; then
+        # shellcheck disable=SC2207
+        NODES=(`$DOCKER_COMPOSE_CMD -p $PROVISION_ID ps -q`)
+    fi

Review comment:
       Shall we error out earlier and explicitly log what's the problem when getting nodes?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org