You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2012/11/08 02:34:18 UTC

svn commit: r1406888 - in /httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache: TestCachingHttpClient.java TestProtocolRequirements.java

Author: sebb
Date: Thu Nov  8 01:34:17 2012
New Revision: 1406888

URL: http://svn.apache.org/viewvc?rev=1406888&view=rev
Log:
Fix some obvious boxing in test classes

Modified:
    httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingHttpClient.java
    httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java

Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingHttpClient.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingHttpClient.java?rev=1406888&r1=1406887&r2=1406888&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingHttpClient.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingHttpClient.java Thu Nov  8 01:34:17 2012
@@ -1985,7 +1985,7 @@ public class TestCachingHttpClient {
 		HttpContext ctx = new BasicHttpContext();
 		impl.execute(host, request);
 		impl.execute(host, request, ctx);
-		assertTrue((Boolean)ctx.getAttribute(ExecutionContext.HTTP_REQ_SENT));
+		assertEquals(Boolean.TRUE, ctx.getAttribute(ExecutionContext.HTTP_REQ_SENT));
 	}
 	
 	@Test

Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java?rev=1406888&r1=1406887&r2=1406888&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java Thu Nov  8 01:34:17 2012
@@ -556,7 +556,7 @@ public class TestProtocolRequirements ex
 
         Capture<HttpEntityEnclosingRequest> reqCap = new Capture<HttpEntityEnclosingRequest>();
 
-        EasyMock.expect(post.expectContinue()).andReturn(true).anyTimes();
+        EasyMock.expect(post.expectContinue()).andReturn(Boolean.TRUE).anyTimes();
         EasyMock.expect(
                 mockBackend.execute(EasyMock.eq(host), EasyMock.capture(reqCap),
                         (HttpContext) EasyMock.isNull())).andReturn(originResponse);
@@ -601,7 +601,7 @@ public class TestProtocolRequirements ex
 
         Capture<HttpEntityEnclosingRequest> reqCap = new Capture<HttpEntityEnclosingRequest>();
 
-        EasyMock.expect(post.expectContinue()).andReturn(false).anyTimes();
+        EasyMock.expect(post.expectContinue()).andReturn(Boolean.FALSE).anyTimes();
         EasyMock.expect(
                 mockBackend.execute(EasyMock.eq(host), EasyMock.capture(reqCap),
                         (HttpContext) EasyMock.isNull())).andReturn(originResponse);