[jira] Commented: (THRIFT-1003) Polishing c_glib code

["Anatol Pomozov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934572#action_12934572 ] 

Anatol Pomozov commented on THRIFT-1003:
----------------------------------------

Also the patch fixes *.pc file (adds correct dependencies to glib-2.0)

> Polishing c_glib code
> ---------------------
>
>                 Key: THRIFT-1003
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1003
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Anatol Pomozov
>         Attachments: c_glib_fixes.diff
>
>
> attached patch contains following changes:
> * Added Apache headers to c/h files
> * Use gtester for running tests. We don't need -wrapper script anymore
> * Use one-line macros G_DEFINE_TYPE instead of 15-line class definition
> * Keep formatting closer to glib-like style (one line class definition macroses/remove trailing spaces)
> Given changes are mostly fixing low hanging fruits. It does not change any logic/api.
> There are more chages needed, such as 
>  * using CLASS_TYPE_new functions instead of g_object_new(CLASS_TYPE) 
>  * stop using _set_property (aka reflection) in constructors
>  * check more careful about _ref and _unref handling 
> but this requires more careful refactoring so it will be later in a separate patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.