You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/05/09 20:05:46 UTC

Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Suman Karumuri.


Bugs: aurora-403
    https://issues.apache.org/jira/browse/aurora-403


Repository: aurora


Description
-------

Add a "config" noun with a "list" verb to list jobs defined in a config file.


Diffs
-----

  src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
  src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
  src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
  src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 

Diff: https://reviews.apache.org/r/21273/diff/


Testing
-------

============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py ....

=========================== 4 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 9 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py .........

=========================== 9 passed in 0.80 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .....

=========================== 5 passed in 0.65 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 37 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ..........
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...

========================== 37 passed in 2.10 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_config_noun.py ...

=========================== 3 passed in 0.66 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=========================== 1 passed in 0.67 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_plugins.py ...

=========================== 3 passed in 0.73 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py ....

=========================== 4 passed in 0.88 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .....

=========================== 5 passed in 0.72 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=========================== 2 passed in 0.71 seconds ===========================
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
src.test.python.apache.aurora.client.cli.config                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS


Thanks,

Mark Chu-Carroll


Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/#review42897
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On May 13, 2014, 6:09 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21273/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 6:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-403
>     https://issues.apache.org/jira/browse/aurora-403
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a "config" noun with a "list" verb to list jobs defined in a config file.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
>   src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
>   src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5 
>   src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21273/diff/
> 
> 
> Testing
> -------
> 
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py .........
> 
> =========================== 9 passed in 0.80 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.65 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 37 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ..........
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 37 passed in 2.10 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> =========================== 3 passed in 0.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> =========================== 1 passed in 0.67 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ...
> 
> =========================== 3 passed in 0.73 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ....
> 
> =========================== 4 passed in 0.88 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.72 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.71 seconds ===========================
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
> src.test.python.apache.aurora.client.cli.config                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.

Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/
-----------------------------------------------------------

(Updated May 16, 2014, 11:54 a.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
-------

Rebase to master.


Bugs: aurora-403
    https://issues.apache.org/jira/browse/aurora-403


Repository: aurora


Description
-------

Add a "config" noun with a "list" verb to list jobs defined in a config file.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
  src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
  src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
  src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 

Diff: https://reviews.apache.org/r/21273/diff/


Testing
-------

============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py ....

=========================== 4 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 9 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py .........

=========================== 9 passed in 0.80 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .....

=========================== 5 passed in 0.65 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 37 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ..........
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...

========================== 37 passed in 2.10 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_config_noun.py ...

=========================== 3 passed in 0.66 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=========================== 1 passed in 0.67 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_plugins.py ...

=========================== 3 passed in 0.73 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py ....

=========================== 4 passed in 0.88 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .....

=========================== 5 passed in 0.72 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=========================== 2 passed in 0.71 seconds ===========================
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
src.test.python.apache.aurora.client.cli.config                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS


Thanks,

Mark Chu-Carroll


Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.

Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/#review43138
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/client/cli/config.py
<https://reviews.apache.org/r/21273/#comment77147>

    What does bind do here? A comment may be needed. 


- Suman Karumuri


On May 13, 2014, 6:09 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21273/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 6:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-403
>     https://issues.apache.org/jira/browse/aurora-403
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a "config" noun with a "list" verb to list jobs defined in a config file.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
>   src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
>   src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5 
>   src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21273/diff/
> 
> 
> Testing
> -------
> 
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py .........
> 
> =========================== 9 passed in 0.80 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.65 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 37 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ..........
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 37 passed in 2.10 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> =========================== 3 passed in 0.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> =========================== 1 passed in 0.67 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ...
> 
> =========================== 3 passed in 0.73 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ....
> 
> =========================== 4 passed in 0.88 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.72 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.71 seconds ===========================
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
> src.test.python.apache.aurora.client.cli.config                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.

Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/#review43208
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/config.py
<https://reviews.apache.org/r/21273/#comment77289>

    Same thing the bindings parameters always do. The bindings are a dictionary of Pystachio bindings that get applied to the config.
    


- Mark Chu-Carroll


On May 13, 2014, 2:09 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21273/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 2:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-403
>     https://issues.apache.org/jira/browse/aurora-403
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a "config" noun with a "list" verb to list jobs defined in a config file.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
>   src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
>   src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5 
>   src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21273/diff/
> 
> 
> Testing
> -------
> 
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py .........
> 
> =========================== 9 passed in 0.80 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.65 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 37 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ..........
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 37 passed in 2.10 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> =========================== 3 passed in 0.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> =========================== 1 passed in 0.67 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ...
> 
> =========================== 3 passed in 0.73 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ....
> 
> =========================== 4 passed in 0.88 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.72 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.71 seconds ===========================
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
> src.test.python.apache.aurora.client.cli.config                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.

Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/
-----------------------------------------------------------

(Updated May 13, 2014, 2:09 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
-------

Ran a python checkstyle tool, and removed all of the unnecessary imports it detected.


Bugs: aurora-403
    https://issues.apache.org/jira/browse/aurora-403


Repository: aurora


Description
-------

Add a "config" noun with a "list" verb to list jobs defined in a config file.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
  src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
  src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5 
  src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
  src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 

Diff: https://reviews.apache.org/r/21273/diff/


Testing
-------

============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py ....

=========================== 4 passed in 0.04 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 9 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py .........

=========================== 9 passed in 0.80 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .....

=========================== 5 passed in 0.65 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 37 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ..........
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...

========================== 37 passed in 2.10 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_config_noun.py ...

=========================== 3 passed in 0.66 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=========================== 1 passed in 0.67 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_plugins.py ...

=========================== 3 passed in 0.73 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py ....

=========================== 4 passed in 0.88 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .....

=========================== 5 passed in 0.72 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=========================== 2 passed in 0.71 seconds ===========================
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
src.test.python.apache.aurora.client.cli.config                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS


Thanks,

Mark Chu-Carroll


Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.

Posted by Mark Chu-Carroll <mc...@twopensource.com>.

> On May 13, 2014, 12:46 p.m., David McLaughlin wrote:
> > src/main/python/apache/aurora/client/cli/config.py, lines 21-23
> > <https://reviews.apache.org/r/21273/diff/1/?file=577370#file577370line21>
> >
> >     Is it just me or a lot of these imports unused?

No, you're absolutely right. I started the file with a cut-and-paste, and then didn't go back and clean up the imports. Doing it now.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/#review42836
-----------------------------------------------------------


On May 9, 2014, 2:05 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21273/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 2:05 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-403
>     https://issues.apache.org/jira/browse/aurora-403
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a "config" noun with a "list" verb to list jobs defined in a config file.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
>   src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
>   src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21273/diff/
> 
> 
> Testing
> -------
> 
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py .........
> 
> =========================== 9 passed in 0.80 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.65 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 37 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ..........
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 37 passed in 2.10 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> =========================== 3 passed in 0.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> =========================== 1 passed in 0.67 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ...
> 
> =========================== 3 passed in 0.73 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ....
> 
> =========================== 4 passed in 0.88 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.72 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.71 seconds ===========================
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
> src.test.python.apache.aurora.client.cli.config                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/#review42836
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/config.py
<https://reviews.apache.org/r/21273/#comment76739>

    Is it just me or a lot of these imports unused?


- David McLaughlin


On May 9, 2014, 6:05 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21273/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 6:05 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-403
>     https://issues.apache.org/jira/browse/aurora-403
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a "config" noun with a "list" verb to list jobs defined in a config file.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
>   src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
>   src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21273/diff/
> 
> 
> Testing
> -------
> 
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py .........
> 
> =========================== 9 passed in 0.80 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.65 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 37 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ..........
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 37 passed in 2.10 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> =========================== 3 passed in 0.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> =========================== 1 passed in 0.67 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ...
> 
> =========================== 3 passed in 0.73 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ....
> 
> =========================== 4 passed in 0.88 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.72 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.71 seconds ===========================
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
> src.test.python.apache.aurora.client.cli.config                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.

Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/#review42833
-----------------------------------------------------------


ping? (just trying to get this back into the mail queue.)

- Mark Chu-Carroll


On May 9, 2014, 2:05 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21273/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 2:05 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-403
>     https://issues.apache.org/jira/browse/aurora-403
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a "config" noun with a "list" verb to list jobs defined in a config file.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
>   src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
>   src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21273/diff/
> 
> 
> Testing
> -------
> 
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.04 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py .........
> 
> =========================== 9 passed in 0.80 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.65 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 37 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ..........
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 37 passed in 2.10 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> =========================== 3 passed in 0.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> =========================== 1 passed in 0.67 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ...
> 
> =========================== 3 passed in 0.73 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ....
> 
> =========================== 4 passed in 0.88 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.72 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.71 seconds ===========================
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
> src.test.python.apache.aurora.client.cli.config                                 .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>