You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2022/04/22 04:15:19 UTC

[Impala-ASF-CR] IMPALA-11237: Preserve the behavior of CONCAT WS() before IMPALA-8891

Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18440


Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891
......................................................................

IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891

This patch preserves the behavior of CONCAT_WS() before IMPALA-8891 by
introducing a flag of 'concat_ws_return_null_if_any_is_null', which is
set to false by default.

Specifically, if 'concat_ws_return_null_if_any_is_null' is set to true
when the Impala daemon is started, CONCAT_WS() will return NULL as long
as any of the argument values is NULL, which corresponds to the behavior
before IMPALA-8891.

Testing:
 - Added an E2E test to verifiy the behavior before IMPALA-8891 could
   be preserved once the flag above is set to true when the Impala
   daemon is started.

Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
---
M be/src/exprs/string-functions-ir.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
A testdata/workloads/functional-query/queries/QueryTest/test_concat_ws.test
A tests/custom_cluster/test_concat_ws.py
5 files changed, 100 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18440/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
Gerrit-Change-Number: 18440
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>

[Impala-ASF-CR] IMPALA-11237: Preserve the behavior of CONCAT WS() before IMPALA-8891

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18440 )

Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891
......................................................................


Patch Set 3:

Build Successful 

https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/10204/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
Gerrit-Change-Number: 18440
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 18:22:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11237: Preserve the behavior of CONCAT WS() before IMPALA-8891

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18440 )

Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10482/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
Gerrit-Change-Number: 18440
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 18:22:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11237: Preserve the behavior of CONCAT WS() before IMPALA-8891

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18440 )

Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891
......................................................................

IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891

This patch preserves the behavior of CONCAT_WS() before IMPALA-8891 by
introducing a flag of 'concat_ws_return_null_if_any_is_null', which is
set to false by default.

Specifically, if 'concat_ws_return_null_if_any_is_null' is set to true
when the Impala daemon is started, CONCAT_WS() will return NULL as long
as any of the argument values is NULL, which corresponds to the behavior
before IMPALA-8891.

Testing:
 - Added an E2E test to verifiy the behavior before IMPALA-8891 could
   be preserved once the flag above is set to true when the Impala
   daemon is started.

Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
---
M be/src/exprs/string-functions-ir.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
A testdata/workloads/functional-query/queries/QueryTest/test_concat_ws.test
A tests/custom_cluster/test_concat_ws.py
5 files changed, 117 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18440/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
Gerrit-Change-Number: 18440
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>

[Impala-ASF-CR] IMPALA-11237: Preserve the behavior of CONCAT WS() before IMPALA-8891

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18440 )

Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/10479/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
Gerrit-Change-Number: 18440
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 04:35:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11237: Preserve the behavior of CONCAT WS() before IMPALA-8891

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18440 )

Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18440/1/tests/custom_cluster/test_concat_ws.py
File tests/custom_cluster/test_concat_ws.py:

http://gerrit.cloudera.org:8080/#/c/18440/1/tests/custom_cluster/test_concat_ws.py@3
PS1, Line 3: class TestConcatWs(CustomClusterTestSuite):
flake8: E302 expected 2 blank lines, found 1



-- 
To view, visit http://gerrit.cloudera.org:8080/18440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
Gerrit-Change-Number: 18440
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 04:16:10 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11237: Preserve the behavior of CONCAT WS() before IMPALA-8891

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18440 )

Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/10481/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
Gerrit-Change-Number: 18440
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 17:42:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11237: Preserve the behavior of CONCAT WS() before IMPALA-8891

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18440 )

Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891
......................................................................


Patch Set 2:

Build Failed 

https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/10203/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
Gerrit-Change-Number: 18440
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 17:42:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11237: Preserve the behavior of CONCAT WS() before IMPALA-8891

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18440 )

Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891
......................................................................

IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891

This patch preserves the behavior of CONCAT_WS() before IMPALA-8891 by
introducing a flag of 'concat_ws_return_null_if_any_is_null', which is
set to false by default.

Specifically, if 'concat_ws_return_null_if_any_is_null' is set to true
when the Impala daemon is started, CONCAT_WS() will return NULL as long
as any of the argument values is NULL, which corresponds to the behavior
before IMPALA-8891.

Testing:
 - Added an E2E test to verifiy the behavior before IMPALA-8891 could
   be preserved once the flag above is set to true when the Impala
   daemon is started.

Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
---
M be/src/exprs/string-functions-ir.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
A testdata/workloads/functional-query/queries/QueryTest/test_concat_ws.test
A tests/custom_cluster/test_concat_ws.py
5 files changed, 101 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18440/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6
Gerrit-Change-Number: 18440
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>